pinctrl: samsung: Use unsigned int for number of controller IO mem resources
authorKrzysztof Kozlowski <krzk@kernel.org>
Thu, 15 Jun 2017 16:33:15 +0000 (18:33 +0200)
committerKrzysztof Kozlowski <krzk@kernel.org>
Wed, 19 Jul 2017 05:39:05 +0000 (07:39 +0200)
Number of IO memory resources cannot be negative obviously and the
driver depends silently on this (by iterating from 0 to
nr_ext_resources+1).  Make this requirement explicit.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
drivers/pinctrl/samsung/pinctrl-samsung.c
drivers/pinctrl/samsung/pinctrl-samsung.h

index 1f73dd2..6efb428 100644 (file)
@@ -960,7 +960,7 @@ samsung_pinctrl_get_soc_data(struct samsung_pinctrl_drv_data *d,
        struct samsung_pin_bank *bank;
        struct resource *res;
        void __iomem *virt_base[SAMSUNG_PINCTRL_NUM_RESOURCES];
-       int i;
+       unsigned int i;
 
        id = of_alias_get_id(node, "pinctrl");
        if (id < 0) {
index 15b26c7..49a05f4 100644 (file)
@@ -231,7 +231,7 @@ struct samsung_retention_data {
 struct samsung_pin_ctrl {
        const struct samsung_pin_bank_data *pin_banks;
        u32             nr_banks;
-       int             nr_ext_resources;
+       unsigned int    nr_ext_resources;
        const struct samsung_retention_data *retention_data;
 
        int             (*eint_gpio_init)(struct samsung_pinctrl_drv_data *);