Fix test failure in test_libbcc (#603)

On some systems, was seeing a failure at tests/cc/test_c_api.cc:172 due
to failure to open the /tmp/perf-pid.map file. Looking through the code,
narrowed it down to an invalid use of c_str() on a temporary
std::string. Fix it by storing the string in a variable.

Signed-off-by: Brenden Blanco <bblanco@plumgrid.com>

diff --git a/tests/cc/test_c_api.cc b/tests/cc/test_c_api.cc
index dae7aa9..4d290e6 100644 (file)
--- a/tests/cc/test_c_api.cc
+++ b/tests/cc/test_c_api.cc
@@ -123,8 +123,8 @@ static string perf_map_path(pid_t pid) {
 static int child_func(void *arg) {
   unsigned long long map_addr = (unsigned long long)arg;
 
-  const char *path = perf_map_path(getpid()).c_str();
-  FILE *file = fopen(path, "w");
+  string path = perf_map_path(getpid());
+  FILE *file = fopen(path.c_str(), "w");
   if (file == NULL) {
     return -1;
   }
@@ -134,7 +134,7 @@ static int child_func(void *arg) {
 
   sleep(5);
 
-  unlink(path);
+  unlink(path.c_str());
   return 0;
 }