#include "precomp.hpp"
#include "opencv2/imgproc.hpp"
#include <stdio.h>
+#include <AvailabilityMacros.h>
#import <AVFoundation/AVFoundation.h>
#define CV_CAP_MODE_BGR CV_FOURCC_MACRO('B','G','R','3')
class CvVideoWriter_AVFoundation : public CvVideoWriter {
public:
- CvVideoWriter_AVFoundation(const char* filename, int fourcc,
- double fps, CvSize frame_size,
- int is_color=1);
+ CvVideoWriter_AVFoundation(const std::string &filename, int fourcc, double fps, CvSize frame_size, int is_color);
~CvVideoWriter_AVFoundation();
bool writeFrame(const IplImage* image) CV_OVERRIDE;
int getCaptureDomain() const CV_OVERRIDE { return cv::CAP_AVFOUNDATION; }
+ bool isOpened() const
+ {
+ return is_good;
+ }
private:
IplImage* argbimage;
CvSize movieSize;
int movieColor;
unsigned long mFrameNum;
+ bool is_good;
};
/****************** Implementation of interface functions ********************/
cv::Ptr<cv::IVideoWriter> cv::create_AVFoundation_writer(const std::string& filename, int fourcc, double fps, const cv::Size &frameSize, bool isColor)
{
CvSize sz = { frameSize.width, frameSize.height };
- CvVideoWriter_AVFoundation* wrt = new CvVideoWriter_AVFoundation(filename.c_str(), fourcc, fps, sz, isColor);
- return cv::makePtr<cv::LegacyWriter>(wrt);
+ CvVideoWriter_AVFoundation* wrt = new CvVideoWriter_AVFoundation(filename, fourcc, fps, sz, isColor);
+ if (wrt->isOpened())
+ {
+ return cv::makePtr<cv::LegacyWriter>(wrt);
+ }
+ delete wrt;
+ return NULL;
}
/********************** Implementation of Classes ****************************/
*****************************************************************************/
-CvVideoWriter_AVFoundation::CvVideoWriter_AVFoundation(const char* filename, int fourcc,
- double fps, CvSize frame_size,
- int is_color) {
-
+CvVideoWriter_AVFoundation::CvVideoWriter_AVFoundation(const std::string &filename, int fourcc, double fps, CvSize frame_size, int is_color)
+ : argbimage(nil), mMovieWriter(nil), mMovieWriterInput(nil), mMovieWriterAdaptor(nil), path(nil),
+ codec(nil), fileType(nil), mMovieFPS(fps), movieSize(frame_size), movieColor(is_color), mFrameNum(0),
+ is_good(true)
+{
+ if (mMovieFPS <= 0 || movieSize.width <= 0 || movieSize.height <= 0)
+ {
+ is_good = false;
+ return;
+ }
NSAutoreleasePool* localpool = [[NSAutoreleasePool alloc] init];
-
- mFrameNum = 0;
- mMovieFPS = fps;
- movieSize = frame_size;
- movieColor = is_color;
argbimage = cvCreateImage(movieSize, IPL_DEPTH_8U, 4);
- path = [[[NSString stringWithCString:filename encoding:NSASCIIStringEncoding] stringByExpandingTildeInPath] retain];
-
-
- /*
- AVFileTypeQuickTimeMovie
- UTI for the QuickTime movie file format.
- The value of this UTI is com.apple.quicktime-movie. Files are identified with the .mov and .qt extensions.
-
- AVFileTypeMPEG4
- UTI for the MPEG-4 file format.
- The value of this UTI is public.mpeg-4. Files are identified with the .mp4 extension.
-
- AVFileTypeAppleM4V
- UTI for the iTunes video file format.
- The value of this UTI is com.apple.mpeg-4-video. Files are identified with the .m4v extension.
-
- AVFileType3GPP
- UTI for the 3GPP file format.
- The value of this UTI is public.3gpp. Files are identified with the .3gp, .3gpp, and .sdv extensions.
- */
+ path = [[[NSString stringWithUTF8String:filename.c_str()] stringByExpandingTildeInPath] retain];
NSString *fileExt =[[[path pathExtension] lowercaseString] copy];
if ([fileExt isEqualToString:@"mov"] || [fileExt isEqualToString:@"qt"]){
fileType = [AVFileTypeMPEG4 copy];
}else if ([fileExt isEqualToString:@"m4v"]){
fileType = [AVFileTypeAppleM4V copy];
-#if TARGET_OS_IPHONE || TARGET_IPHONE_SIMULATOR
- }else if ([fileExt isEqualToString:@"3gp"] || [fileExt isEqualToString:@"3gpp"] || [fileExt isEqualToString:@"sdv"] ){
- fileType = [AVFileType3GPP copy];
-#endif
} else{
- fileType = [AVFileTypeMPEG4 copy]; //default mp4
+ is_good = false;
}
[fileExt release];
cc[4] = 0;
int cc2 = CV_FOURCC(cc[0], cc[1], cc[2], cc[3]);
if (cc2!=fourcc) {
- fprintf(stderr, "OpenCV: Didn't properly encode FourCC. Expected 0x%08X but got 0x%08X.\n", fourcc, cc2);
- //exception;
+ is_good = false;
}
// Two codec supported AVVideoCodecH264 AVVideoCodecJPEG
}else if(fourcc == CV_FOURCC('H','2','6','4') || fourcc == CV_FOURCC('a','v','c','1')){
codec = [AVVideoCodecH264 copy];
}else{
- codec = [AVVideoCodecH264 copy]; // default canonical H264.
-
+ is_good = false;
}
//NSLog(@"Path: %@", path);
- NSError *error = nil;
-
+ if (is_good)
+ {
+ NSError *error = nil;
- // Make sure the file does not already exist. Necessary to overwirte??
- /*
- NSFileManager *fileManager = [NSFileManager defaultManager];
- if ([fileManager fileExistsAtPath:path]){
- [fileManager removeItemAtPath:path error:&error];
- }
- */
- // Wire the writer:
- // Supported file types:
- // AVFileTypeQuickTimeMovie AVFileTypeMPEG4 AVFileTypeAppleM4V AVFileType3GPP
+ // Make sure the file does not already exist. Necessary to overwirte??
+ /*
+ NSFileManager *fileManager = [NSFileManager defaultManager];
+ if ([fileManager fileExistsAtPath:path]){
+ [fileManager removeItemAtPath:path error:&error];
+ }
+ */
- mMovieWriter = [[AVAssetWriter alloc] initWithURL:[NSURL fileURLWithPath:path]
- fileType:fileType
- error:&error];
- //NSParameterAssert(mMovieWriter);
+ // Wire the writer:
+ // Supported file types:
+ // AVFileTypeQuickTimeMovie AVFileTypeMPEG4 AVFileTypeAppleM4V AVFileType3GPP
- NSDictionary *videoSettings = [NSDictionary dictionaryWithObjectsAndKeys:
- codec, AVVideoCodecKey,
- [NSNumber numberWithInt:movieSize.width], AVVideoWidthKey,
- [NSNumber numberWithInt:movieSize.height], AVVideoHeightKey,
- nil];
+ mMovieWriter = [[AVAssetWriter alloc] initWithURL:[NSURL fileURLWithPath:path]
+ fileType:fileType
+ error:&error];
+ //NSParameterAssert(mMovieWriter);
- mMovieWriterInput = [[AVAssetWriterInput
- assetWriterInputWithMediaType:AVMediaTypeVideo
- outputSettings:videoSettings] retain];
+ NSDictionary *videoSettings = [NSDictionary dictionaryWithObjectsAndKeys:
+ codec, AVVideoCodecKey,
+ [NSNumber numberWithInt:movieSize.width], AVVideoWidthKey,
+ [NSNumber numberWithInt:movieSize.height], AVVideoHeightKey,
+ nil];
- //NSParameterAssert(mMovieWriterInput);
- //NSParameterAssert([mMovieWriter canAddInput:mMovieWriterInput]);
+ mMovieWriterInput = [[AVAssetWriterInput
+ assetWriterInputWithMediaType:AVMediaTypeVideo
+ outputSettings:videoSettings] retain];
- [mMovieWriter addInput:mMovieWriterInput];
+ //NSParameterAssert(mMovieWriterInput);
+ //NSParameterAssert([mMovieWriter canAddInput:mMovieWriterInput]);
- mMovieWriterAdaptor = [[AVAssetWriterInputPixelBufferAdaptor alloc] initWithAssetWriterInput:mMovieWriterInput sourcePixelBufferAttributes:nil];
+ [mMovieWriter addInput:mMovieWriterInput];
+ mMovieWriterAdaptor = [[AVAssetWriterInputPixelBufferAdaptor alloc] initWithAssetWriterInput:mMovieWriterInput sourcePixelBufferAttributes:nil];
- //Start a session:
- [mMovieWriter startWriting];
- [mMovieWriter startSessionAtSourceTime:kCMTimeZero];
+ //Start a session:
+ [mMovieWriter startWriting];
+ [mMovieWriter startSessionAtSourceTime:kCMTimeZero];
- if(mMovieWriter.status == AVAssetWriterStatusFailed){
- NSLog(@"AVF: AVAssetWriter status: %@", [mMovieWriter.error localizedDescription]);
- // TODO: error handling, cleanup. Throw execption?
- // return;
+ if(mMovieWriter.status == AVAssetWriterStatusFailed){
+ NSLog(@"AVF: AVAssetWriter status: %@", [mMovieWriter.error localizedDescription]);
+ is_good = false;
+ }
}
[localpool drain];
CvVideoWriter_AVFoundation::~CvVideoWriter_AVFoundation() {
NSAutoreleasePool* localpool = [[NSAutoreleasePool alloc] init];
- [mMovieWriterInput markAsFinished];
- [mMovieWriter finishWriting];
- [mMovieWriter release];
- [mMovieWriterInput release];
- [mMovieWriterAdaptor release];
- [path release];
- [codec release];
- [fileType release];
- cvReleaseImage(&argbimage);
+ if (mMovieWriterInput && mMovieWriter && mMovieWriterAdaptor)
+ {
+ [mMovieWriterInput markAsFinished];
+ [mMovieWriter finishWriting];
+ [mMovieWriter release];
+ [mMovieWriterInput release];
+ [mMovieWriterAdaptor release];
+ }
+ if (path)
+ [path release];
+ if (codec)
+ [codec release];
+ if (fileType)
+ [fileType release];
+ if (argbimage)
+ cvReleaseImage(&argbimage);
[localpool drain];
int getCaptureDomain() const CV_OVERRIDE { return cv::CAP_GSTREAMER; }
- bool open(const char* filename, int fourcc,
+ bool open(const std::string &filename, int fourcc,
double fps, const Size &frameSize, bool isColor );
void close();
bool writeFrame( const IplImage* image ) CV_OVERRIDE;
* If the file extension did was not recognize, an avi container is used
*
*/
-bool CvVideoWriter_GStreamer::open( const char * filename, int fourcc,
+bool CvVideoWriter_GStreamer::open( const std::string &filename, int fourcc,
double fps, const cv::Size &frameSize, bool is_color )
{
// check arguments
- assert (filename);
- assert (fps > 0);
- assert (frameSize.width > 0 && frameSize.height > 0);
+ if (filename.empty() || frameSize.width <= 0 || frameSize.height <= 0 || fps <= 0)
+ return false;
// init gstreamer
gst_initializer::init();
// we first try to construct a pipeline from the given string.
// if that fails, we assume it is an ordinary filename
- encodebin = gst_parse_launch(filename, &err);
+ encodebin = gst_parse_launch(filename.c_str(), &err);
manualpipeline = (encodebin != NULL);
if(manualpipeline)
}
//create container caps from file extension
- mime = filenameToMimetype(filename);
+ mime = filenameToMimetype(filename.c_str());
if (!mime) {
CV_WARN("Gstreamer Opencv backend does not support this file type.");
return false;
g_object_set(G_OBJECT(encodebin), "profile", containerprofile, NULL);
source = gst_element_factory_make("appsrc", NULL);
file = gst_element_factory_make("filesink", NULL);
- g_object_set(G_OBJECT(file), "location", filename, NULL);
+ g_object_set(G_OBJECT(file), "location", filename.c_str(), NULL);
}
if (fourcc == CV_FOURCC('M','J','P','G') && frameSize.height == 1)
return true;
}
-Ptr<IVideoWriter> cv::create_GStreamer_writer(const std::string& filename, int fourcc, double fps, const cv::Size &frameSize, bool isColor)
+Ptr<IVideoWriter> cv::create_GStreamer_writer(const std::string &filename, int fourcc, double fps, const cv::Size &frameSize, bool isColor)
{
CvVideoWriter_GStreamer* wrt = new CvVideoWriter_GStreamer;
- if (wrt->open(filename.c_str(), fourcc, fps, frameSize, isColor))
+ if (wrt->open(filename, fourcc, fps, frameSize, isColor))
return makePtr<LegacyWriter>(wrt);
-
delete wrt;
return 0;
}
remove(filename.c_str());
}
+TEST(videoio_dynamic, write_invalid)
+{
+ vector<VideoCaptureAPIs> backends = videoio_registry::getWriterBackends();
+ for (VideoCaptureAPIs be : backends)
+ {
+ SCOPED_TRACE(be);
+ const string filename = cv::tempfile(".mkv");
+ VideoWriter writer;
+ bool res = true;
+
+ // Bad FourCC
+ EXPECT_NO_THROW(res = writer.open(filename, be, VideoWriter::fourcc('A', 'B', 'C', 'D'), 1, Size(640, 480), true));
+ EXPECT_FALSE(res);
+ EXPECT_FALSE(writer.isOpened());
+
+ // Empty filename
+ EXPECT_NO_THROW(res = writer.open(String(), be, VideoWriter::fourcc('H', '2', '6', '4'), 1, Size(640, 480), true));
+ EXPECT_FALSE(res);
+ EXPECT_FALSE(writer.isOpened());
+ EXPECT_NO_THROW(res = writer.open(String(), be, VideoWriter::fourcc('M', 'J', 'P', 'G'), 1, Size(640, 480), true));
+ EXPECT_FALSE(res);
+ EXPECT_FALSE(writer.isOpened());
+
+ // zero FPS
+ EXPECT_NO_THROW(res = writer.open(filename, be, VideoWriter::fourcc('H', '2', '6', '4'), 0, Size(640, 480), true));
+ EXPECT_FALSE(res);
+ EXPECT_FALSE(writer.isOpened());
+
+ // cleanup
+ EXPECT_NO_THROW(writer.release());
+ remove(filename.c_str());
+ }
+
+ // Generic
+ {
+ VideoWriter writer;
+ bool res = true;
+ EXPECT_NO_THROW(res = writer.open(std::string(), VideoWriter::fourcc('H', '2', '6', '4'), 1, Size(640, 480)));
+ EXPECT_FALSE(res);
+ EXPECT_FALSE(writer.isOpened());
+ EXPECT_NO_THROW(res = writer.open(std::string(), VideoWriter::fourcc('M', 'J', 'P', 'G'), 1, Size(640, 480)));
+ EXPECT_FALSE(res);
+ EXPECT_FALSE(writer.isOpened());
+ }
+}
+
}} // opencv_test::<anonymous>::
projects / platform / upstream / opencv.git / commitdiff