Fix unittests for ewk_settings_text_autosizing_font_scale_factor_set_func
authorTomasz Czekala <t.czekala@partner.samsung.com>
Fri, 30 Jan 2015 09:07:35 +0000 (10:07 +0100)
committerYoungsoo Choi <kenshin.choi@samsung.com>
Tue, 10 Jul 2018 06:57:09 +0000 (06:57 +0000)
ewk_settings_text_autosizing_font_scale_factor_set_func expects the argument to
be a double value, but was provided a boolean, that was converted to double, but
the unittest was treating in wrong way

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9535
Reviewed by: Hyunhak Kim, Piotr Tworek

Change-Id: I1863d0b8b2f4d6a2365e854f78b56ad0f4538754
Signed-off-by: Tomasz Czekala <t.czekala@partner.samsung.com>
tizen_src/ewk/unittest/utc_blink_ewk_settings_text_autosizing_font_scale_factor_set_func.cpp

index 990b330..dde6838 100644 (file)
@@ -22,19 +22,21 @@ protected:
 /**
  * @brief Positive test case of ewk_settings_text_autosizing_font_scale_factor_set()
  */
-TEST_F(utc_blink_ewk_settings_text_autosizing_font_scale_factor_set_func, SetTrue)
+TEST_F(utc_blink_ewk_settings_text_autosizing_font_scale_factor_set_func, SetPositive)
 {
-  ASSERT_TRUE(ewk_settings_text_autosizing_font_scale_factor_set(settings, EINA_TRUE));
-  EXPECT_TRUE(ewk_settings_text_autosizing_font_scale_factor_get(settings));
+  double factor = 1.23;
+  ASSERT_TRUE(ewk_settings_text_autosizing_font_scale_factor_set(settings, factor));
+  double setFactor = ewk_settings_text_autosizing_font_scale_factor_get(settings);
+  const double delta = 0.001;
+  EXPECT_TRUE((factor - setFactor) < delta && (setFactor - factor) < delta);
 }
 
 /**
  * @brief Positive test case of ewk_settings_text_autosizing_font_scale_factor_set()
  */
-TEST_F(utc_blink_ewk_settings_text_autosizing_font_scale_factor_set_func, SetFalse)
+TEST_F(utc_blink_ewk_settings_text_autosizing_font_scale_factor_set_func, SetNegative)
 {
-  ASSERT_TRUE(ewk_settings_text_autosizing_font_scale_factor_set(settings, EINA_FALSE));
-  EXPECT_FALSE(ewk_settings_text_autosizing_font_scale_factor_get(settings));
+  EXPECT_FALSE(ewk_settings_text_autosizing_font_scale_factor_set(settings, -1.0));
 }
 
 /**
@@ -42,5 +44,5 @@ TEST_F(utc_blink_ewk_settings_text_autosizing_font_scale_factor_set_func, SetFal
  */
 TEST_F(utc_blink_ewk_settings_text_autosizing_font_scale_factor_set_func, InvalidArg)
 {
-  EXPECT_FALSE(ewk_settings_text_autosizing_font_scale_factor_set(NULL, EINA_TRUE));
+  EXPECT_FALSE(ewk_settings_text_autosizing_font_scale_factor_set(NULL, 1.0));
 }