spi: dw: Quite logging on deferred controller registration
authorSerge Semin <Sergey.Semin@baikalelectronics.ru>
Mon, 22 Aug 2022 18:18:53 +0000 (21:18 +0300)
committerMark Brown <broonie@kernel.org>
Tue, 23 Aug 2022 12:06:36 +0000 (13:06 +0100)
It's pretty possible to have the spi_register_controller() method
returning -EPROBE_DEFER status in case, for instance, if the GPIOs used
for the CS implementation aren't ready to be requested due to the
corresponding platform devices still pending to be probed. Let's make sure
the DW SSI driver won't print error message in that case by calling the
dev_err_probe() function if the SPI-registration procedure exited with
a non-zero status.

Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Link: https://lore.kernel.org/r/20220822181853.23063-1-Sergey.Semin@baikalelectronics.ru
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-dw-core.c

index f87d97c..99edddf 100644 (file)
@@ -955,7 +955,7 @@ int dw_spi_add_host(struct device *dev, struct dw_spi *dws)
 
        ret = spi_register_controller(master);
        if (ret) {
-               dev_err(&master->dev, "problem registering spi master\n");
+               dev_err_probe(dev, ret, "problem registering spi master\n");
                goto err_dma_exit;
        }