Fix some crash in create api 96/130796/1
authorSeokHoon Lee <andy.shlee@samsung.com>
Wed, 24 May 2017 04:22:07 +0000 (13:22 +0900)
committerSeokHoon Lee <andy.shlee@samsung.com>
Wed, 24 May 2017 04:22:25 +0000 (13:22 +0900)
 - There is a availablity in create api,
   when unaccessable memory position as input parameter(*scmirroring_h).

Signed-off-by: SeokHoon Lee <andy.shlee@samsung.com>
Change-Id: Ieb1e2b0f5a530e57f51a7c2af0f138d6aa124295

packaging/capi-media-screen-mirroring.spec
src/scmirroring_sink.c
src/scmirroring_src.c

index 3ae492558d91fba8bf7ebc8fca1b2cfbbca243a5..1798a1da1ed2f380d1d6f9e054e4182a84e91dcd 100644 (file)
@@ -1,6 +1,6 @@
 Name:       capi-media-screen-mirroring
 Summary:    A screen mirroring library in Tizen C API
-Version:    0.1.78
+Version:    0.1.79
 Release:    0
 Group:      Multimedia/API
 License:    Apache-2.0
index 7ac4fba369dfbd486d8b0ea67cc3853bc089be68..8d160fa56297a0b02964c728fcffdff7a8526948 100644 (file)
@@ -114,12 +114,6 @@ int scmirroring_sink_create(scmirroring_sink_h *scmirroring_sink)
 
        scmirroring_retvm_if(scmirroring_sink == NULL, SCMIRRORING_ERROR_INVALID_PARAMETER, "scmirroring_sink is NULL");
 
-       scmirroring_sink_s *mhandle = (scmirroring_sink_s *)(*scmirroring_sink);
-       if (mhandle != NULL && mhandle->magic_num == SCMIRRORING_MAGIC_NUMBER) {
-               scmirroring_error("Already created handle");
-               return SCMIRRORING_ERROR_INVALID_PARAMETER;
-       }
-
        scmirroring_sink_s *handle = (scmirroring_sink_s *)calloc(1, sizeof(scmirroring_sink_s));
        scmirroring_retvm_if(handle == NULL, SCMIRRORING_ERROR_OUT_OF_MEMORY, "Fail to allocate memory for handle");
 
index 3102e9b9c360f74db2022d424a478254788be9f2..11f38379c3140b7ae1db4c40dc75e5f8a2ead6ca 100644 (file)
@@ -408,12 +408,6 @@ int scmirroring_src_create(scmirroring_src_h *scmirroring)
 
        scmirroring_retvm_if(scmirroring == NULL, SCMIRRORING_ERROR_INVALID_PARAMETER, "Handle is NULL");
 
-       scmirroring_src_s *mhandle = (scmirroring_src_s *)(*scmirroring);
-       if (mhandle != NULL && mhandle->magic_num == SCMIRRORING_MAGIC_NUMBER) {
-               scmirroring_error("Already created handle");
-               return SCMIRRORING_ERROR_INVALID_PARAMETER;
-       }
-
        _scmirroring = (scmirroring_src_s *)calloc(1, sizeof(scmirroring_src_s));
        scmirroring_retvm_if(_scmirroring == NULL, SCMIRRORING_ERROR_OUT_OF_MEMORY, "OUT_OF_MEMORY");