ath10k: remove a copy of the NAPI_POLL_WEIGHT define
authorJakub Kicinski <kuba@kernel.org>
Fri, 29 Apr 2022 17:46:42 +0000 (10:46 -0700)
committerKalle Valo <quic_kvalo@quicinc.com>
Mon, 2 May 2022 14:00:11 +0000 (17:00 +0300)
Defining local versions of NAPI_POLL_WEIGHT with the same
values in the drivers just makes refactoring harder.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Link: https://lore.kernel.org/r/20220429174643.196994-3-kuba@kernel.org
drivers/net/wireless/ath/ath10k/core.h
drivers/net/wireless/ath/ath10k/pci.c
drivers/net/wireless/ath/ath10k/sdio.c
drivers/net/wireless/ath/ath10k/snoc.c
drivers/net/wireless/ath/ath10k/usb.c

index 9f6680b3be0a748cc3e2d958bcfa17242d2c82c6..8bfabbcfdb143ae025b835219c3b83d08674b512 100644 (file)
@@ -59,9 +59,6 @@
 #define ATH10K_KEEPALIVE_MAX_IDLE 3895
 #define ATH10K_KEEPALIVE_MAX_UNRESPONSIVE 3900
 
-/* NAPI poll budget */
-#define ATH10K_NAPI_BUDGET      64
-
 /* SMBIOS type containing Board Data File Name Extension */
 #define ATH10K_SMBIOS_BDF_EXT_TYPE 0xF8
 
index 4d4e2f91e15cfa8b491d4705246221da00b51b6f..bf1c938be7d0a2889d8181c8219142ce0d5e0232 100644 (file)
@@ -3216,7 +3216,7 @@ static void ath10k_pci_free_irq(struct ath10k *ar)
 void ath10k_pci_init_napi(struct ath10k *ar)
 {
        netif_napi_add(&ar->napi_dev, &ar->napi, ath10k_pci_napi_poll,
-                      ATH10K_NAPI_BUDGET);
+                      NAPI_POLL_WEIGHT);
 }
 
 static int ath10k_pci_init_irq(struct ath10k *ar)
index 63e1c2d783c5fe29ca030ac1f2f497d658b5dac9..9162b02b72113fc3923f1a85257908e5fc78a138 100644 (file)
@@ -2532,7 +2532,7 @@ static int ath10k_sdio_probe(struct sdio_func *func,
        }
 
        netif_napi_add(&ar->napi_dev, &ar->napi, ath10k_sdio_napi_poll,
-                      ATH10K_NAPI_BUDGET);
+                      NAPI_POLL_WEIGHT);
 
        ath10k_dbg(ar, ATH10K_DBG_BOOT,
                   "sdio new func %d vendor 0x%x device 0x%x block 0x%x/0x%x\n",
index 8328966a0471c6830b98e8ede61e45de03244562..607e8164bf984000ca357684eb93cd9b041ca2ed 100644 (file)
@@ -1243,7 +1243,7 @@ static int ath10k_snoc_napi_poll(struct napi_struct *ctx, int budget)
 static void ath10k_snoc_init_napi(struct ath10k *ar)
 {
        netif_napi_add(&ar->napi_dev, &ar->napi, ath10k_snoc_napi_poll,
-                      ATH10K_NAPI_BUDGET);
+                      NAPI_POLL_WEIGHT);
 }
 
 static int ath10k_snoc_request_irq(struct ath10k *ar)
index 10df6ca303a1c351eccabc3c56d4fbf78323c1ec..ad6471b217964b2a9a5c1da457deda059a95f4c0 100644 (file)
@@ -1015,7 +1015,7 @@ static int ath10k_usb_probe(struct usb_interface *interface,
        }
 
        netif_napi_add(&ar->napi_dev, &ar->napi, ath10k_usb_napi_poll,
-                      ATH10K_NAPI_BUDGET);
+                      NAPI_POLL_WEIGHT);
 
        usb_get_dev(dev);
        vendor_id = le16_to_cpu(dev->descriptor.idVendor);