nfp: fix return statement in nfp_net_parse_meta()
authorNiklas Söderlund <niklas.soderlund@corigine.com>
Thu, 22 Jul 2021 11:25:02 +0000 (13:25 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 18 Sep 2021 11:40:21 +0000 (13:40 +0200)
[ Upstream commit 4431531c482a2c05126caaa9fcc5053a4a5c495b ]

The return type of the function is bool and while NULL do evaluate to
false it's not very nice, fix this by explicitly returning false. There
is no functional change.

Signed-off-by: Niklas Söderlund <niklas.soderlund@corigine.com>
Signed-off-by: Louis Peens <louis.peens@corigine.com>
Signed-off-by: Simon Horman <simon.horman@corigine.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/netronome/nfp/nfp_net_common.c

index 4372268..dfc1f32 100644 (file)
@@ -1697,7 +1697,7 @@ nfp_net_parse_meta(struct net_device *netdev, struct nfp_meta_parsed *meta,
                case NFP_NET_META_RESYNC_INFO:
                        if (nfp_net_tls_rx_resync_req(netdev, data, pkt,
                                                      pkt_len))
-                               return NULL;
+                               return false;
                        data += sizeof(struct nfp_net_tls_resync_req);
                        break;
                default: