udf: Drop pointless check from udf_sync_fs()
authorJan Kara <jack@suse.cz>
Tue, 19 Feb 2019 13:59:43 +0000 (14:59 +0100)
committerJan Kara <jack@suse.cz>
Thu, 21 Feb 2019 18:25:36 +0000 (19:25 +0100)
The check if (bh) in udf_sync_fs() is pointless as we cannot have
sbi->s_lvid_dirty and !sbi->s_lvid_bh (as already asserted by
udf_updated_lvid()). So just drop the pointless check.

Reviewed-by: Steven J. Magnani <steve@digidescorp.com>
Reported-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Jan Kara <jack@suse.cz>
fs/udf/super.c

index a6940d9..ffd8038 100644 (file)
@@ -2330,13 +2330,10 @@ static int udf_sync_fs(struct super_block *sb, int wait)
        mutex_lock(&sbi->s_alloc_mutex);
        if (sbi->s_lvid_dirty) {
                struct buffer_head *bh = sbi->s_lvid_bh;
+               struct logicalVolIntegrityDesc *lvid;
 
-               if (bh) {
-                       struct logicalVolIntegrityDesc *lvid;
-
-                       lvid = (struct logicalVolIntegrityDesc *)bh->b_data;
-                       udf_finalize_lvid(lvid);
-               }
+               lvid = (struct logicalVolIntegrityDesc *)bh->b_data;
+               udf_finalize_lvid(lvid);
 
                /*
                 * Blockdevice will be synced later so we don't have to submit