Fix several defects

- Fix misuse of fsync().
- Adjust log level of sendToServer()'s erorr.

Change-Id: I04b0fa76beeee64bb3181de9a31d32634d748a62
Signed-off-by: sangwan.kwon <sangwan.kwon@samsung.com>

diff --git a/src/client/client-password.cpp b/src/client/client-password.cpp
index bd7e6bb67523acb725ac134f48aae0271b0c989d..69dbd67aedd3b0d408313165ef89eadf481a991a 100644 (file)
--- a/src/client/client-password.cpp
+++ b/src/client/client-password.cpp
@@ -82,7 +82,7 @@ int auth_passwd_check_passwd(password_type passwd_type,
                int retCode = sendToServer(SERVICE_SOCKET_PASSWD_CHECK, send.Pop(), recv);
 
                if (AUTH_PASSWD_API_SUCCESS != retCode) {
-                       LogDebug("Error in sendToServer. Error code: " << retCode);
+                       LogError("Error in sendToServer. Error code: " << retCode);
                        return retCode;
                }
 
@@ -132,7 +132,7 @@ int auth_passwd_check_passwd_state(password_type passwd_type,
                int retCode = sendToServer(SERVICE_SOCKET_PASSWD_CHECK, send.Pop(), recv);
 
                if (AUTH_PASSWD_API_SUCCESS != retCode) {
-                       LogDebug("Error in sendToServer. Error code: " << retCode);
+                       LogError("Error in sendToServer. Error code: " << retCode);
                        return retCode;
                }
 
@@ -167,7 +167,7 @@ int auth_passwd_check_passwd_available(password_type passwd_type, const char *pa
                int retCode = sendToServer(SERVICE_SOCKET_PASSWD_CHECK, send.Pop(), recv);
 
                if (AUTH_PASSWD_API_SUCCESS != retCode) {
-                       LogDebug("Error in sendToServer. Error code: " << retCode);
+                       LogError("Error in sendToServer. Error code: " << retCode);
                        return retCode;
                }
 
@@ -198,7 +198,7 @@ int auth_passwd_check_passwd_reused(password_type passwd_type,
                int retCode = sendToServer(SERVICE_SOCKET_PASSWD_SET, send.Pop(), recv);
 
                if (AUTH_PASSWD_API_SUCCESS != retCode) {
-                       LogDebug("Error in sendToServer. Error code: " << retCode);
+                       LogError("Error in sendToServer. Error code: " << retCode);
                        return retCode;
                }
 

diff --git a/src/server/service/password-file-buffer.cpp b/src/server/service/password-file-buffer.cpp
index 19025656254da6c4eac0c56b76662bf59cc34b16..aa3ecf69b2683866be184455a2510e5b4dae48fa 100644 (file)
--- a/src/server/service/password-file-buffer.cpp
+++ b/src/server/service/password-file-buffer.cpp
@@ -85,7 +85,7 @@ void PasswordFileBuffer::Save(const std::string &path)
        }
 
        file.flush();
-       if (::fsync(DPL::FstreamAccessors<std::ofstream>::GetFd(file) != 0)) // flush kernel space buffer
+       if (::fsync(DPL::FstreamAccessors<std::ofstream>::GetFd(file)) != 0)
                LogError("Failed to synchronize a file's state.");
        file.close();
 }

diff --git a/src/server/service/password-file.cpp b/src/server/service/password-file.cpp
index a2d958d07168eae1f171fe377f128c4bb20a07d7..68b72beac1c2e28ea9b817d0f7f761957b546eeb 100644 (file)
--- a/src/server/service/password-file.cpp
+++ b/src/server/service/password-file.cpp
@@ -370,7 +370,7 @@ void PasswordFile::writeAttemptToFile() const
        }
 
        AttemptFile.flush();
-       if (::fsync(DPL::FstreamAccessors<std::ofstream>::GetFd(AttemptFile) != 0)) // flush kernel space buffer
+       if (::fsync(DPL::FstreamAccessors<std::ofstream>::GetFd(AttemptFile)) != 0)
                LogError("Failed to synchronize a file's state.");
        AttemptFile.close();
 }