libs/gst/controller/gstcontroller.c: Better if we actually iterate the list :)

Original commit message from CVS:
* libs/gst/controller/gstcontroller.c: (gst_controller_new_list):
Better if we actually iterate the list :)

diff --git a/ChangeLog b/ChangeLog
index 4d381c9..799a1b0 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2005-09-29  Edward Hervey  <edward@fluendo.com>
+
+       * libs/gst/controller/gstcontroller.c: (gst_controller_new_list): 
+       Better if we actually iterate the list :)
+
 2005-09-29  Wim Taymans  <wim@fluendo.com>
 
        * check/gst/gstbin.c: (GST_START_TEST):

diff --git a/libs/gst/controller/gstcontroller.c b/libs/gst/controller/gstcontroller.c
index 81725d0..e55aba7 100644 (file)
--- a/libs/gst/controller/gstcontroller.c
+++ b/libs/gst/controller/gstcontroller.c
@@ -469,7 +469,7 @@ gst_controller_new_list (GObject * object, GList * list)
 
   self = g_object_get_qdata (object, __gst_controller_key);
   /* create GstControlledProperty for each property */
-  for (node = list; node; node = g_list_next (list)) {
+  for (node = list; node; node = g_list_next (node)) {
     name = (gchar *) node->data;
     /* test if this property isn't yet controlled */
     if (!self || !(prop = gst_controller_find_controlled_property (self, name))) {