[flang] Disable pipefail for tests for stdin input
authorDavid Spickett <david.spickett@linaro.org>
Wed, 27 Jul 2022 09:26:22 +0000 (09:26 +0000)
committerDavid Spickett <david.spickett@linaro.org>
Wed, 27 Jul 2022 10:31:02 +0000 (10:31 +0000)
We have seen the llvm test fail every so often on our bots:
https://lab.llvm.org/buildbot/#/builders/173/builds/6711

This happens because `flang-new -fc1 -S` does not wait for the
pipe to finish being written to/does not read out all the content.
You can see this in the output, cat comes after flang:
+ /home/tcwg-buildbot/worker/flang-aarch64-release/build/bin/not /home/tcwg-buildbot/worker/flang-aarch64-release/build/bin/flang-new -fc1 -S - -o -
+ cat /home/tcwg-buildbot/worker/flang-aarch64-release/llvm-project/flang/test/Driver/input-from-stdin-llvm.ll
error: Invalid input type - expecting a Fortran file

This means that cat gets SIGPIPE which causes it to exit with
code 141 and that's the final result due to pipefail.

flang isn't wrong to exit early (I think some modes of grep also do this)
and we only care about flang's exit code. So disable pipefail for
the stdin testing.

Reviewed By: awarzynski

Differential Revision: https://reviews.llvm.org/D130619

flang/test/Driver/input-from-stdin/input-from-stdin-llvm.ll [moved from flang/test/Driver/input-from-stdin-llvm.ll with 100% similarity]
flang/test/Driver/input-from-stdin/input-from-stdin.f90 [moved from flang/test/Driver/input-from-stdin.f90 with 100% similarity]
flang/test/Driver/input-from-stdin/lit.local.cfg [new file with mode: 0644]

diff --git a/flang/test/Driver/input-from-stdin/lit.local.cfg b/flang/test/Driver/input-from-stdin/lit.local.cfg
new file mode 100644 (file)
index 0000000..11dc664
--- /dev/null
@@ -0,0 +1,3 @@
+# In some modes flang will exit before cat does. If pipefail is enabled this means
+# we get cat's exit code not flang's.
+config.pipefail = False