power: supply: gpio-charger: Simplify with dev_err_probe()
authorKrzysztof Kozlowski <krzk@kernel.org>
Wed, 26 Aug 2020 14:48:56 +0000 (16:48 +0200)
committerSebastian Reichel <sebastian.reichel@collabora.com>
Wed, 26 Aug 2020 15:25:42 +0000 (17:25 +0200)
Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and also it prints the error value.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
drivers/power/supply/gpio-charger.c

index 875735d..557f879 100644 (file)
@@ -173,10 +173,8 @@ static int gpio_charger_probe(struct platform_device *pdev)
                gpio_charger->gpiod = gpio_to_desc(pdata->gpio);
        } else if (IS_ERR(gpio_charger->gpiod)) {
                /* Just try again if this happens */
-               if (PTR_ERR(gpio_charger->gpiod) == -EPROBE_DEFER)
-                       return -EPROBE_DEFER;
-               dev_err(dev, "error getting GPIO descriptor\n");
-               return PTR_ERR(gpio_charger->gpiod);
+               return dev_err_probe(dev, PTR_ERR(gpio_charger->gpiod),
+                                    "error getting GPIO descriptor\n");
        }
 
        if (gpio_charger->gpiod) {