projects
/
platform
/
kernel
/
linux-rpi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
08d6749
)
dmaengine: coh901318: Fix a double lock bug in dma_tc_handle()
author
Dan Carpenter
<dan.carpenter@oracle.com>
Mon, 17 Feb 2020 14:40:50 +0000
(17:40 +0300)
committer
Greg Kroah-Hartman
<gregkh@linuxfoundation.org>
Thu, 12 Mar 2020 12:00:30 +0000
(13:00 +0100)
commit
36d5d22090d13fd3a7a8c9663a711cbe6970aac8
upstream.
The caller is already holding the lock so this will deadlock.
Fixes:
0b58828c923e
("DMAENGINE: COH 901 318 remove irq counting")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link:
https://lore.kernel.org/r/20200217144050.3i4ymbytogod4ijn@kili.mountain
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/dma/coh901318.c
patch
|
blob
|
history
diff --git
a/drivers/dma/coh901318.c
b/drivers/dma/coh901318.c
index
e51d836
..
1092d4c
100644
(file)
--- a/
drivers/dma/coh901318.c
+++ b/
drivers/dma/coh901318.c
@@
-1947,8
+1947,6
@@
static void dma_tc_handle(struct coh901318_chan *cohc)
return;
}
- spin_lock(&cohc->lock);
-
/*
* When we reach this point, at least one queue item
* should have been moved over from cohc->queue to
@@
-1969,8
+1967,6
@@
static void dma_tc_handle(struct coh901318_chan *cohc)
if (coh901318_queue_start(cohc) == NULL)
cohc->busy = 0;
- spin_unlock(&cohc->lock);
-
/*
* This tasklet will remove items from cohc->active
* and thus terminates them.