debugfs: remove return value of debugfs_create_file_size()

No one checks the return value of debugfs_create_file_size, as it's not
needed, so make the return value void, so that no one tries to do so in
the future.

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Link: https://lore.kernel.org/r/20200309163640.237984-1-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/Documentation/filesystems/debugfs.txt b/Documentation/filesystems/debugfs.txt
index 55336a4..2e66df5 100644 (file)
--- a/Documentation/filesystems/debugfs.txt
+++ b/Documentation/filesystems/debugfs.txt
@@ -55,10 +55,10 @@ missing.
 Create a file with an initial size, the following function can be used
 instead:
 
-    struct dentry *debugfs_create_file_size(const char *name, umode_t mode,
-                               struct dentry *parent, void *data,
-                               const struct file_operations *fops,
-                               loff_t file_size);
+    void debugfs_create_file_size(const char *name, umode_t mode,
+                                 struct dentry *parent, void *data,
+                                 const struct file_operations *fops,
+                                 loff_t file_size);
 
 file_size is the initial file size. The other parameters are the same
 as the function debugfs_create_file.

diff --git a/fs/debugfs/inode.c b/fs/debugfs/inode.c
index e742dfc..b7f2e97 100644 (file)
--- a/fs/debugfs/inode.c
+++ b/fs/debugfs/inode.c
@@ -501,26 +501,16 @@ EXPORT_SYMBOL_GPL(debugfs_create_file_unsafe);
  * wide range of flexibility in creating a file, or a directory (if you want
  * to create a directory, the debugfs_create_dir() function is
  * recommended to be used instead.)
- *
- * This function will return a pointer to a dentry if it succeeds.  This
- * pointer must be passed to the debugfs_remove() function when the file is
- * to be removed (no automatic cleanup happens if your module is unloaded,
- * you are responsible here.)  If an error occurs, ERR_PTR(-ERROR) will be
- * returned.
- *
- * If debugfs is not enabled in the kernel, the value -%ENODEV will be
- * returned.
  */
-struct dentry *debugfs_create_file_size(const char *name, umode_t mode,
-                                       struct dentry *parent, void *data,
-                                       const struct file_operations *fops,
-                                       loff_t file_size)
+void debugfs_create_file_size(const char *name, umode_t mode,
+                             struct dentry *parent, void *data,
+                             const struct file_operations *fops,
+                             loff_t file_size)
 {
        struct dentry *de = debugfs_create_file(name, mode, parent, data, fops);
 
        if (de)
                d_inode(de)->i_size = file_size;
-       return de;
 }
 EXPORT_SYMBOL_GPL(debugfs_create_file_size);
 

diff --git a/include/linux/debugfs.h b/include/linux/debugfs.h
index 43efcc4..d672b7d 100644 (file)
--- a/include/linux/debugfs.h
+++ b/include/linux/debugfs.h
@@ -67,10 +67,10 @@ struct dentry *debugfs_create_file_unsafe(const char *name, umode_t mode,
                                   struct dentry *parent, void *data,
                                   const struct file_operations *fops);
 
-struct dentry *debugfs_create_file_size(const char *name, umode_t mode,
-                                       struct dentry *parent, void *data,
-                                       const struct file_operations *fops,
-                                       loff_t file_size);
+void debugfs_create_file_size(const char *name, umode_t mode,
+                             struct dentry *parent, void *data,
+                             const struct file_operations *fops,
+                             loff_t file_size);
 
 struct dentry *debugfs_create_dir(const char *name, struct dentry *parent);
 
@@ -181,13 +181,11 @@ static inline struct dentry *debugfs_create_file_unsafe(const char *name,
        return ERR_PTR(-ENODEV);
 }
 
-static inline struct dentry *debugfs_create_file_size(const char *name, umode_t mode,
-                                       struct dentry *parent, void *data,
-                                       const struct file_operations *fops,
-                                       loff_t file_size)
-{
-       return ERR_PTR(-ENODEV);
-}
+static inline void debugfs_create_file_size(const char *name, umode_t mode,
+                                           struct dentry *parent, void *data,
+                                           const struct file_operations *fops,
+                                           loff_t file_size)
+{ }
 
 static inline struct dentry *debugfs_create_dir(const char *name,
                                                struct dentry *parent)