thermal: int340x: delete bogus length check
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 30 Sep 2021 12:28:03 +0000 (15:28 +0300)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Tue, 5 Oct 2021 14:46:27 +0000 (16:46 +0200)
This check has a signedness bug and does not work.  If "length" is
larger than "PAGE_SIZE" then "PAGE_SIZE - length" is not negative
but instead it is a large unsigned value.  Fortunately, Takashi Iwai
changed this code to use scnprint() instead of snprintf() so now
"length" is never larger than "PAGE_SIZE - 1" and the check can be
removed.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/thermal/intel/int340x_thermal/int3400_thermal.c

index 19926be..8502b7d 100644 (file)
@@ -129,11 +129,10 @@ static ssize_t available_uuids_show(struct device *dev,
 
        for (i = 0; i < INT3400_THERMAL_MAXIMUM_UUID; i++) {
                if (priv->uuid_bitmap & (1 << i))
-                       if (PAGE_SIZE - length > 0)
-                               length += scnprintf(&buf[length],
-                                                  PAGE_SIZE - length,
-                                                  "%s\n",
-                                                  int3400_thermal_uuids[i]);
+                       length += scnprintf(&buf[length],
+                                           PAGE_SIZE - length,
+                                           "%s\n",
+                                           int3400_thermal_uuids[i]);
        }
 
        return length;