mailbox: arm_mhuv2: Fix return value check in mhuv2_probe()
authorYang Yingliang <yangyingliang@huawei.com>
Fri, 25 Nov 2022 06:35:48 +0000 (14:35 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 31 Dec 2022 12:32:55 +0000 (13:32 +0100)
[ Upstream commit 165b7643f2df890066b1b4e8a387888a600ca9bf ]

If devm_of_iomap() fails, it returns ERR_PTR() and never
return NULL, so replace NULL pointer check with IS_ERR()
to fix this problem.

Fixes: 5a6338cce9f4 ("mailbox: arm_mhuv2: Add driver")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/mailbox/arm_mhuv2.c

index a47aef8..c6d4957 100644 (file)
@@ -1062,8 +1062,8 @@ static int mhuv2_probe(struct amba_device *adev, const struct amba_id *id)
        int ret = -EINVAL;
 
        reg = devm_of_iomap(dev, dev->of_node, 0, NULL);
-       if (!reg)
-               return -ENOMEM;
+       if (IS_ERR(reg))
+               return PTR_ERR(reg);
 
        mhu = devm_kzalloc(dev, sizeof(*mhu), GFP_KERNEL);
        if (!mhu)