perf tests: Add test for the java demangler
authorNick Gasson <nick.gasson@arm.com>
Mon, 27 Apr 2020 06:15:16 +0000 (14:15 +0800)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Thu, 28 May 2020 13:03:28 +0000 (10:03 -0300)
Split from a larger patch that was also fixing a problem with the java
demangler, so, before applying that patch we see:

  $ perf test java
  65: Demangle Java                                         : FAILED!
  $ perf test -v java
  65: Demangle Java                                         :
  --- start ---
  test child forked, pid 307264
  FAILED: Ljava/lang/StringLatin1;equals([B[B)Z: bool class java.lang.StringLatin1.equals(byte[], byte[]) != boolean java.lang.StringLatin1.equals(byte[], byte[])
  FAILED: Ljava/util/zip/ZipUtils;CENSIZ([BI)J: long class java.util.zip.ZipUtils.CENSIZ(byte[], int) != long java.util.zip.ZipUtils.CENSIZ(byte[], int)
  FAILED: Ljava/util/regex/Pattern$BmpCharProperty;match(Ljava/util/regex/Matcher;ILjava/lang/CharSequence;)Z: bool class java.util.regex.Pattern$BmpCharProperty.match(class java.util.regex.Matcher., int, class java.lang., charhar, shortequence) != boolean java.util.regex.Pattern$BmpCharProperty.match(java.util.regex.Matcher, int, java.lang.CharSequence)
  FAILED: Ljava/lang/AbstractStringBuilder;appendChars(Ljava/lang/String;II)V: void class java.lang.AbstractStringBuilder.appendChars(class java.lang., shorttring., int, int) != void java.lang.AbstractStringBuilder.appendChars(java.lang.String, int, int)
  FAILED: Ljava/lang/Object;<init>()V: void class java.lang.Object<init>() != void java.lang.Object<init>()
  test child finished with -1
  ---- end ----
  Demangle Java: FAILED!
  $

Next patch should fix this.

Signed-off-by: Nick Gasson <nick.gasson@arm.com>
Reviewed-by: Ian Rogers <irogers@google.com>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Tested-by: Ian Rogers <irogers@google.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lore.kernel.org/lkml/20200427061520.24905-4-nick.gasson@arm.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/tests/Build
tools/perf/tests/builtin-test.c
tools/perf/tests/demangle-java-test.c [new file with mode: 0644]
tools/perf/tests/tests.h

index c75557aeef0e7580f87fae74fda008caf42d5ffc..446fe14c24cf633ba2d02d00444054537e72787b 100644 (file)
@@ -57,6 +57,7 @@ perf-y += maps.o
 perf-y += time-utils-test.o
 perf-y += genelf.o
 perf-y += api-io.o
+perf-y += demangle-java-test.o
 
 $(OUTPUT)tests/llvm-src-base.c: tests/bpf-script-example.c tests/Build
        $(call rule_mkdir)
index a9daaeb9fd274cfcc0aed65305ca1d6384a27900..f1dc2fe93dd8077606c0ec4c2af70299f3c20d96 100644 (file)
@@ -324,6 +324,10 @@ static struct test generic_tests[] = {
                .desc = "maps__merge_in",
                .func = test__maps__merge_in,
        },
+       {
+               .desc = "Demangle Java",
+               .func = test__demangle_java,
+       },
        {
                .func = NULL,
        },
diff --git a/tools/perf/tests/demangle-java-test.c b/tools/perf/tests/demangle-java-test.c
new file mode 100644 (file)
index 0000000..8f3b908
--- /dev/null
@@ -0,0 +1,42 @@
+// SPDX-License-Identifier: GPL-2.0
+#include <string.h>
+#include <stdlib.h>
+#include <stdio.h>
+#include "tests.h"
+#include "session.h"
+#include "debug.h"
+#include "demangle-java.h"
+
+int test__demangle_java(struct test *test __maybe_unused, int subtest __maybe_unused)
+{
+       int ret = TEST_OK;
+       char *buf = NULL;
+       size_t i;
+
+       struct {
+               const char *mangled, *demangled;
+       } test_cases[] = {
+               { "Ljava/lang/StringLatin1;equals([B[B)Z",
+                 "boolean java.lang.StringLatin1.equals(byte[], byte[])" },
+               { "Ljava/util/zip/ZipUtils;CENSIZ([BI)J",
+                 "long java.util.zip.ZipUtils.CENSIZ(byte[], int)" },
+               { "Ljava/util/regex/Pattern$BmpCharProperty;match(Ljava/util/regex/Matcher;ILjava/lang/CharSequence;)Z",
+                 "boolean java.util.regex.Pattern$BmpCharProperty.match(java.util.regex.Matcher, int, java.lang.CharSequence)" },
+               { "Ljava/lang/AbstractStringBuilder;appendChars(Ljava/lang/String;II)V",
+                 "void java.lang.AbstractStringBuilder.appendChars(java.lang.String, int, int)" },
+               { "Ljava/lang/Object;<init>()V",
+                 "void java.lang.Object<init>()" },
+       };
+
+       for (i = 0; i < sizeof(test_cases) / sizeof(test_cases[0]); i++) {
+               buf = java_demangle_sym(test_cases[i].mangled, 0);
+               if (strcmp(buf, test_cases[i].demangled)) {
+                       pr_debug("FAILED: %s: %s != %s\n", test_cases[i].mangled,
+                                buf, test_cases[i].demangled);
+                       ret = TEST_FAIL;
+               }
+               free(buf);
+       }
+
+       return ret;
+}
index 6c6c4b6a4796bca86e985f215bafce193d78407d..12856bc6f411859eca583b372ab17697a5f41cb0 100644 (file)
@@ -117,6 +117,7 @@ int test__maps__merge_in(struct test *t, int subtest);
 int test__time_utils(struct test *t, int subtest);
 int test__jit_write_elf(struct test *test, int subtest);
 int test__api_io(struct test *test, int subtest);
+int test__demangle_java(struct test *test, int subtest);
 
 bool test__bp_signal_is_supported(void);
 bool test__bp_account_is_supported(void);