staging: r8188eu: bCardDisableWOHSM is write-only
authorMartin Kaiser <martin@kaiser.cx>
Sun, 23 Oct 2022 17:08:08 +0000 (19:08 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 25 Oct 2022 17:22:52 +0000 (19:22 +0200)
bCardDisableWOHSM in struct adapter is only written but never read.
It can be removed.

Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150
Link: https://lore.kernel.org/r/20221023170808.46233-6-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/r8188eu/include/drv_types.h
drivers/staging/r8188eu/os_dep/os_intfs.c

index 1bd0c8f..8fef575 100644 (file)
@@ -167,7 +167,6 @@ struct adapter {
 
        s32     bDriverStopped;
        s32     bSurpriseRemoved;
-       s32     bCardDisableWOHSM;
 
        u8      hw_init_completed;
        s8      signal_strength;
index 38e3247..970f380 100644 (file)
@@ -620,7 +620,6 @@ static int _netdev_open(struct net_device *pnetdev)
        if (!padapter->bup) {
                padapter->bDriverStopped = false;
                padapter->bSurpriseRemoved = false;
-               padapter->bCardDisableWOHSM = false;
 
                status = rtw_hal_init(padapter);
                if (status == _FAIL)
@@ -686,7 +685,6 @@ static int  ips_netdrv_open(struct adapter *padapter)
 
        padapter->bDriverStopped = false;
        padapter->bSurpriseRemoved = false;
-       padapter->bCardDisableWOHSM = false;
 
        status = rtw_hal_init(padapter);
        if (status == _FAIL)
@@ -718,13 +716,11 @@ int rtw_ips_pwr_up(struct adapter *padapter)
 
 void rtw_ips_pwr_down(struct adapter *padapter)
 {
-       padapter->bCardDisableWOHSM = true;
        padapter->net_closed = true;
 
        rtw_led_control(padapter, LED_CTL_POWER_OFF);
 
        rtw_ips_dev_unload(padapter);
-       padapter->bCardDisableWOHSM = false;
 }
 
 static void rtw_fifo_cleanup(struct adapter *adapter)