staging: lustre: llite: Remove unnecessary test in if condition
authorAmitoj Kaur Chawla <amitoj1606@gmail.com>
Wed, 2 Mar 2016 20:02:14 +0000 (01:32 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 2 Mar 2016 23:28:13 +0000 (15:28 -0800)
Remove unnecessary test on `rc` variable since it has already been
tested previously.
Fixes following smatch warning:
drivers/staging/lustre/lustre/llite/llite_lib.c:1331 ll_setattr_raw()
warn: we tested 'rc' before and it was 'false'

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/lustre/lustre/llite/llite_lib.c

index acdae25..6d6bb33 100644 (file)
@@ -1328,7 +1328,7 @@ int ll_setattr_raw(struct dentry *dentry, struct iattr *attr, bool hsm_import)
        }
 
        /* RPC to MDT is sent, cancel data modification flag */
-       if (rc == 0 && (op_data->op_bias & MDS_DATA_MODIFIED)) {
+       if (op_data->op_bias & MDS_DATA_MODIFIED) {
                spin_lock(&lli->lli_lock);
                lli->lli_flags &= ~LLIF_DATA_MODIFIED;
                spin_unlock(&lli->lli_lock);