ARM: dts: exynos: Correct USB3503 GPIOs polarity
authorMarek Szyprowski <m.szyprowski@samsung.com>
Wed, 11 Dec 2019 14:51:55 +0000 (15:51 +0100)
committerKrzysztof Kozlowski <krzk@kernel.org>
Thu, 12 Dec 2019 20:18:36 +0000 (21:18 +0100)
Current USB3503 driver ignores GPIO polarity and always operates as if the
GPIO lines were flagged as ACTIVE_HIGH. Fix the polarity for the existing
USB3503 chip applications to match the chip specification and common
convention for naming the pins. The only pin, which has to be ACTIVE_LOW
is the reset pin. The remaining are ACTIVE_HIGH. This change allows later
to fix the USB3503 driver to properly use generic GPIO bindings and read
polarity from DT.

Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
arch/arm/boot/dts/exynos4412-odroid-common.dtsi
arch/arm/boot/dts/exynos5250-arndale.dts
arch/arm/boot/dts/exynos5410-odroidxu.dts

index ea55f37..9c39e82 100644 (file)
 
                intn-gpios = <&gpx3 0 GPIO_ACTIVE_HIGH>;
                connect-gpios = <&gpx3 4 GPIO_ACTIVE_HIGH>;
-               reset-gpios = <&gpx3 5 GPIO_ACTIVE_HIGH>;
+               reset-gpios = <&gpx3 5 GPIO_ACTIVE_LOW>;
                initial-mode = <1>;
        };
 
index d6c85ef..3eddf5d 100644 (file)
                compatible = "smsc,usb3503a";
 
                reset-gpios = <&gpx3 5 GPIO_ACTIVE_LOW>;
-               connect-gpios = <&gpd1 7 GPIO_ACTIVE_LOW>;
+               connect-gpios = <&gpd1 7 GPIO_ACTIVE_HIGH>;
        };
 };
 
index e0db251..4f9297a 100644 (file)
 
                intn-gpios = <&gpx0 7 GPIO_ACTIVE_HIGH>;
                connect-gpios = <&gpx0 6 GPIO_ACTIVE_HIGH>;
-               reset-gpios = <&gpx1 4 GPIO_ACTIVE_HIGH>;
+               reset-gpios = <&gpx1 4 GPIO_ACTIVE_LOW>;
                initial-mode = <1>;
 
                clock-names = "refclk";