power_supply: 88pm860x_charger: Decrement the power supply's device reference counter
authorKrzysztof Kozlowski <k.kozlowski@samsung.com>
Thu, 12 Mar 2015 07:44:17 +0000 (08:44 +0100)
committerSebastian Reichel <sre@kernel.org>
Fri, 13 Mar 2015 22:15:54 +0000 (23:15 +0100)
Use power_supply_put() to decrement the power supply's device reference
counter.

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Reviewed-by: Sebastian Reichel <sre@kernel.org>
Signed-off-by: Sebastian Reichel <sre@kernel.org>
drivers/power/88pm860x_charger.c

index a7f32a5..bf822aa 100644 (file)
@@ -298,13 +298,18 @@ static int set_charging_fsm(struct pm860x_charger_info *info)
                return -EINVAL;
        ret = power_supply_get_property(psy, POWER_SUPPLY_PROP_VOLTAGE_NOW,
                        &data);
-       if (ret)
+       if (ret) {
+               power_supply_put(psy);
                return ret;
+       }
        vbatt = data.intval / 1000;
 
        ret = power_supply_get_property(psy, POWER_SUPPLY_PROP_PRESENT, &data);
-       if (ret)
+       if (ret) {
+               power_supply_put(psy);
                return ret;
+       }
+       power_supply_put(psy);
 
        mutex_lock(&info->lock);
        info->present = data.intval;
@@ -447,6 +452,7 @@ static irqreturn_t pm860x_temp_handler(int irq, void *data)
 
        set_charging_fsm(info);
 out:
+       power_supply_put(psy);
        return IRQ_HANDLED;
 }
 
@@ -507,6 +513,7 @@ static irqreturn_t pm860x_done_handler(int irq, void *data)
 
 out:
        mutex_unlock(&info->lock);
+       power_supply_put(psy);
        dev_dbg(info->dev, "%s, Allowed: %d\n", __func__, info->allowed);
        set_charging_fsm(info);