drm/amdgpu: Fix static checker warning
authorRex Zhu <Rex.Zhu@amd.com>
Fri, 23 Nov 2018 10:52:21 +0000 (18:52 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Mon, 26 Nov 2018 20:47:34 +0000 (15:47 -0500)
drivers/gpu/drm/amd/amdgpu/amdgpu_csa.c:49 amdgpu_allocate_static_csa()
error: uninitialized symbol 'ptr'.

the test if (!bo) doesn't work, as the bo is a pointer to a pointer.
if bo create failed, the *bo will be set to NULL.
so change to test *bo.

Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Rex Zhu <Rex.Zhu@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_csa.c

index 0c590dd..5b55070 100644 (file)
@@ -43,7 +43,7 @@ int amdgpu_allocate_static_csa(struct amdgpu_device *adev, struct amdgpu_bo **bo
        r = amdgpu_bo_create_kernel(adev, size, PAGE_SIZE,
                                domain, bo,
                                NULL, &ptr);
-       if (!bo)
+       if (!*bo)
                return -ENOMEM;
 
        memset(ptr, 0, size);