phy: renesas: rcar-gen3-usb2: disable runtime pm in case of failure
authorWang Li <wangli74@huawei.com>
Thu, 26 Nov 2020 02:44:12 +0000 (10:44 +0800)
committerVinod Koul <vkoul@kernel.org>
Sat, 5 Dec 2020 08:06:12 +0000 (13:36 +0530)
pm_runtime_enable() will decrease power disable depth. Thus a pairing
increment is needed on the error handling path to keep it balanced.

Fixes: 5d8042e95fd4 ("phy: rcar-gen3-usb2: Add support for r8a77470")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Li <wangli74@huawei.com>
Link: https://lore.kernel.org/r/20201126024412.4046845-1-wangli74@huawei.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/renesas/phy-rcar-gen3-usb2.c

index 1898bbe..fbc5523 100644 (file)
@@ -654,8 +654,10 @@ static int rcar_gen3_phy_usb2_probe(struct platform_device *pdev)
         */
        pm_runtime_enable(dev);
        phy_usb2_ops = of_device_get_match_data(dev);
-       if (!phy_usb2_ops)
-               return -EINVAL;
+       if (!phy_usb2_ops) {
+               ret = -EINVAL;
+               goto error;
+       }
 
        mutex_init(&channel->lock);
        for (i = 0; i < NUM_OF_PHYS; i++) {