staging: r8188eu: remove unnecessary rtw_free_xmitframe call
authorMartin Kaiser <martin@kaiser.cx>
Fri, 30 Dec 2022 18:06:43 +0000 (19:06 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 17 Jan 2023 18:31:23 +0000 (19:31 +0100)
There's no need to call rtw_free_xmitframe before we dequeue the first
frame. pxmitframe is always NULL at this point, rtw_free_xmitframe will do
nothing in this case.

Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150
Link: https://lore.kernel.org/r/20221230180646.91008-18-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/r8188eu/hal/rtl8188eu_xmit.c

index cf9779b86b9cb0b65226f7a65b0d93b02e9a4272..d1af76cc2091bdb32c46a4372a9fc96234660113 100644 (file)
@@ -398,9 +398,6 @@ bool rtl8188eu_xmitframe_complete(struct adapter *adapt, struct xmit_priv *pxmit
        if (!pxmitbuf)
                return false;
 
-       /* 3 1. pick up first frame */
-       rtw_free_xmitframe(pxmitpriv, pxmitframe);
-
        pxmitframe = rtw_dequeue_xframe(pxmitpriv, pxmitpriv->hwxmits, pxmitpriv->hwxmit_entry);
        if (!pxmitframe) {
                /*  no more xmit frame, release xmit buffer */