android: Remove error checking for debugfs_create_dir()
authorWang Ming <machel@vivo.com>
Thu, 13 Jul 2023 08:06:37 +0000 (16:06 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 4 Aug 2023 13:28:01 +0000 (15:28 +0200)
It is expected that most callers should _ignore_ the errors
return by debugfs_create_dir() in binder_init().

Signed-off-by: Wang Ming <machel@vivo.com>
Link: https://lore.kernel.org/r/20230713080649.1893-1-machel@vivo.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/android/binder.c

index 486c827..49d84a6 100644 (file)
@@ -6557,6 +6557,7 @@ static int __init binder_init(void)
        struct binder_device *device;
        struct hlist_node *tmp;
        char *device_names = NULL;
+       const struct binder_debugfs_entry *db_entry;
 
        ret = binder_alloc_shrinker_init();
        if (ret)
@@ -6566,19 +6567,16 @@ static int __init binder_init(void)
        atomic_set(&binder_transaction_log_failed.cur, ~0U);
 
        binder_debugfs_dir_entry_root = debugfs_create_dir("binder", NULL);
-       if (binder_debugfs_dir_entry_root) {
-               const struct binder_debugfs_entry *db_entry;
 
-               binder_for_each_debugfs_entry(db_entry)
-                       debugfs_create_file(db_entry->name,
-                                           db_entry->mode,
-                                           binder_debugfs_dir_entry_root,
-                                           db_entry->data,
-                                           db_entry->fops);
+       binder_for_each_debugfs_entry(db_entry)
+               debugfs_create_file(db_entry->name,
+                                       db_entry->mode,
+                                       binder_debugfs_dir_entry_root,
+                                       db_entry->data,
+                                       db_entry->fops);
 
-               binder_debugfs_dir_entry_proc = debugfs_create_dir("proc",
-                                                binder_debugfs_dir_entry_root);
-       }
+       binder_debugfs_dir_entry_proc = debugfs_create_dir("proc",
+                                               binder_debugfs_dir_entry_root);
 
        if (!IS_ENABLED(CONFIG_ANDROID_BINDERFS) &&
            strcmp(binder_devices_param, "") != 0) {