Fix broken wakeup() in threaded renderloop.

It is cruicial that the sync handshake between GUI and render
does not get interrupted. If it does, the sync will happen with
the GUI unlocked which leads to crashes. When the sync event
comes through to the GUI afterwards the GUI will block waiting
while the renderer is most likely already done with the sync,
causing GUI to wait indefinitely.

Change-Id: I00bf0c36088510609a9e6f4d0649b9aaeefcd241
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>

diff --git a/src/quick/items/qquickwindowmanager.cpp b/src/quick/items/qquickwindowmanager.cpp
index d075d3b..0a378f6 100644 (file)
--- a/src/quick/items/qquickwindowmanager.cpp
+++ b/src/quick/items/qquickwindowmanager.cpp
@@ -1121,7 +1121,7 @@ void QQuickRenderThreadSingleContextWindowManager::wakeup()
 {
     lockInGui();
     isExternalUpdatePending = true;
-    if (isRenderBlocked || isPostingSyncEvent)
+    if (isRenderBlocked)
         wake();
     unlockInGui();
 }