remoteproc: core: Move validate before device add

We can validate whether the remoteproc is correctly setup before
making the cdev_add and device_add calls. This saves us the
trouble of cleaning up later on.

Signed-off-by: Siddharth Gupta <sidgup@codeaurora.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Link: https://lore.kernel.org/r/1623723671-5517-3-git-send-email-sidgup@codeaurora.org
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>

diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
index 9ad8c5f..b65fce3 100644 (file)
--- a/drivers/remoteproc/remoteproc_core.c
+++ b/drivers/remoteproc/remoteproc_core.c
@@ -2333,16 +2333,16 @@ int rproc_add(struct rproc *rproc)
        struct device *dev = &rproc->dev;
        int ret;
 
-       /* add char device for this remoteproc */
-       ret = rproc_char_device_add(rproc);
+       ret = rproc_validate(rproc);
        if (ret < 0)
                return ret;
 
-       ret = device_add(dev);
+       /* add char device for this remoteproc */
+       ret = rproc_char_device_add(rproc);
        if (ret < 0)
                return ret;
 
-       ret = rproc_validate(rproc);
+       ret = device_add(dev);
        if (ret < 0)
                return ret;