Remove the high-priority flag from IdleNotification() since

it is a strange API and unused anyway.

When we roll this to Chrome, we'll need a small chrome patch
to fix Chrome's usage of the API.

Review URL: http://codereview.chromium.org/257035

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3019 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

diff --git a/include/v8.h b/include/v8.h
index 4992d75542c030641ef8a6df86d1a473c48a717c..adb9f431766a6e173b5a9df029c915c756dab9f9 100644 (file)
--- a/include/v8.h
+++ b/include/v8.h
@@ -2349,12 +2349,11 @@ class V8EXPORT V8 {
    * Optional notification that the embedder is idle.
    * V8 uses the notification to reduce memory footprint.
    * This call can be used repeatedly if the embedder remains idle.
-   * \param is_high_priority tells whether the embedder is high priority.
    * Returns true if the embedder should stop calling IdleNotification
    * until real work has been done.  This indicates that V8 has done
    * as much cleanup as it will be able to do.
    */
-  static bool IdleNotification(bool is_high_priority);
+  static bool IdleNotification();
 
   /**
    * Optional notification that the system is running low on memory.

diff --git a/src/api.cc b/src/api.cc
index fd3d921734f1d14cea49acf6da0f964531fced8c..00f1e0b7e156dd3f4a8810ddcb90f580450cefc0 100644 (file)
--- a/src/api.cc
+++ b/src/api.cc
@@ -2602,11 +2602,11 @@ bool v8::V8::Dispose() {
 }
 
 
-bool v8::V8::IdleNotification(bool is_high_priority) {
+bool v8::V8::IdleNotification() {
   // Returning true tells the caller that it need not
   // continue to call IdleNotification.
   if (!i::V8::IsRunning()) return true;
-  return i::V8::IdleNotification(is_high_priority);
+  return i::V8::IdleNotification();
 }
 
 

diff --git a/src/v8.cc b/src/v8.cc
index f0115ec31eb5443addb64b47fc3c55b836184a5f..3f8e6cdeae055286b7014fbf13d36a1a8a1ee7b4 100644 (file)
--- a/src/v8.cc
+++ b/src/v8.cc
@@ -169,12 +169,10 @@ uint32_t V8::Random() {
 }
 
 
-bool V8::IdleNotification(bool is_high_priority) {
+bool V8::IdleNotification() {
   // Returning true tells the caller that there is no need to call
   // IdleNotification again.
   if (!FLAG_use_idle_notification) return true;
-  // Ignore high priority instances of V8.
-  if (is_high_priority) return true;
 
   // Tell the heap that it may want to adjust.
   return Heap::IdleNotification();

diff --git a/src/v8.h b/src/v8.h
index 7786d66f8d1c0a3477121e5e0c93b84b1b00bea7..106ae612c1fee54f7496e5e8ded1ae5598695bd4 100644 (file)
--- a/src/v8.h
+++ b/src/v8.h
@@ -95,7 +95,7 @@ class V8 : public AllStatic {
   static Smi* RandomPositiveSmi();
 
   // Idle notification directly from the API.
-  static bool IdleNotification(bool is_high_priority);
+  static bool IdleNotification();
 
  private:
   // True if engine is currently running

diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc
index f430cbde03802869c48961d9790008f5c551335f..db89e180f751683eb34a80d7390e63cd8600a5e0 100644 (file)
--- a/test/cctest/test-api.cc
+++ b/test/cctest/test-api.cc
@@ -7916,8 +7916,8 @@ THREADED_TEST(StackTrace) {
 // Test that idle notification can be handled when V8 has not yet been
 // set up.
 THREADED_TEST(IdleNotification) {
-  for (int i = 0; i < 100; i++) v8::V8::IdleNotification(true);
-  for (int i = 0; i < 100; i++) v8::V8::IdleNotification(false);
+  for (int i = 0; i < 100; i++)
+    CHECK(v8::V8::IdleNotification());
 }