fix more bugs with --skip and --until

diff --git a/src/flac/decode.c b/src/flac/decode.c
index 879707c..13c3348 100644 (file)
--- a/src/flac/decode.c
+++ b/src/flac/decode.c
@@ -803,7 +803,8 @@ void metadata_callback(const void *decoder, const FLAC__StreamMetadata *metadata
                FLAC__ASSERT(decoder_session->until_specification->value.samples >= 0);
                until = (FLAC__uint64)decoder_session->until_specification->value.samples;
 
-               decoder_session->total_samples -= (metadata->data.stream_info.total_samples - until);
+               if(until > 0)
+                       decoder_session->total_samples -= (metadata->data.stream_info.total_samples - until);
 
                if(decoder_session->bps != 8 && decoder_session->bps != 16 && decoder_session->bps != 24) {
                        fprintf(stderr, "%s: ERROR: bits per sample is not 8/16/24\n", decoder_session->inbasefilename);

diff --git a/src/flac/encode.c b/src/flac/encode.c
index 22c5727..79a79b9 100644 (file)
--- a/src/flac/encode.c
+++ b/src/flac/encode.c
@@ -278,7 +278,7 @@ flac__encode_aif(FILE *infile, long infilesize, const char *infilename, const ch
                else if(got_ssnd_chunk==false && !strncmp(chunk_id, "SSND", 4)) { /* sound data chunk */
                        unsigned int offset= 0U, block_size= 0U, align_remainder= 0U, data_bytes;
                        size_t bytes_per_frame= channels*(bps>>3);
-                       FLAC__uint64 total_samples_in_input;
+                       FLAC__uint64 total_samples_in_input, trim = 0;
                        FLAC__bool pad= false;
 
                        if(got_comm_chunk==false) {
@@ -352,7 +352,7 @@ flac__encode_aif(FILE *infile, long infilesize, const char *infilename, const ch
                        data_bytes-= (unsigned int)encoder_session.skip*bytes_per_frame; /*@@@ WATCHOUT: 4GB limit */
                        encoder_session.total_samples_to_encode= total_samples_in_input - encoder_session.skip;
                        if(encoder_session.until > 0) {
-                               const FLAC__uint64 trim = total_samples_in_input - encoder_session.until;
+                               trim = total_samples_in_input - encoder_session.until;
                                FLAC__ASSERT(total_samples_in_input > 0);
                                FLAC__ASSERT(!options.common.sector_align);
                                data_bytes-= (unsigned int)trim*bytes_per_frame;
@@ -424,6 +424,29 @@ flac__encode_aif(FILE *infile, long infilesize, const char *infilename, const ch
                                }
                        }
 
+                       if(trim>0) {
+                               FLAC__uint64 remaining= (unsigned int)trim*bytes_per_frame;
+
+                               FLAC__ASSERT(!options.common.sector_align);
+
+                               /* do 1<<30 bytes at a time, since 1<<30 is a nice round number, and */
+                               /* is guaranteed to be less than LONG_MAX */
+                               for(; remaining>0U; remaining-= remaining>(1U<<30) ? remaining : (1U<<30))
+                               {
+                                       unsigned long skip= (unsigned long)(remaining % (1U<<30));
+
+                                       FLAC__ASSERT(skip<=LONG_MAX);
+                                       while(skip>0 && fseek(infile, skip, SEEK_CUR)<0) {
+                                               unsigned int need= min(skip, sizeof ucbuffer_);
+                                               if(fread(ucbuffer_, 1U, need, infile)<need) {
+                                                       fprintf(stderr, "%s: ERROR during read while skipping samples\n", encoder_session.inbasefilename);
+                                                       return EncoderSession_finish_error(&encoder_session);
+                                               }
+                                               skip-= need;
+                                       }
+                               }
+                       }
+
                        /* now read unaligned samples into reservoir or pad with zeroes if necessary */
                        if(options.common.sector_align) {
                                if(options.common.is_last_file) {
@@ -637,7 +660,7 @@ int flac__encode_wav(FILE *infile, long infilesize, const char *infilename, cons
                        got_fmt_chunk = true;
                }
                else if(xx == 0x61746164 && !got_data_chunk && got_fmt_chunk) { /* "data" */
-                       FLAC__uint64 total_samples_in_input;
+                       FLAC__uint64 total_samples_in_input, trim = 0;
 
                        /* data size */
                        if(!read_little_endian_uint32(infile, &xx, false, encoder_session.inbasefilename))
@@ -677,7 +700,7 @@ int flac__encode_wav(FILE *infile, long infilesize, const char *infilename, cons
                        data_bytes -= (unsigned)encoder_session.skip * bytes_per_wide_sample; /*@@@ WATCHOUT: 4GB limit */
                        encoder_session.total_samples_to_encode = total_samples_in_input - encoder_session.skip;
                        if(encoder_session.until > 0) {
-                               const FLAC__uint64 trim = total_samples_in_input - encoder_session.until;
+                               trim = total_samples_in_input - encoder_session.until;
                                FLAC__ASSERT(total_samples_in_input > 0);
                                FLAC__ASSERT(!options.common.sector_align);
                                data_bytes -= (unsigned int)trim * bytes_per_wide_sample;
@@ -753,6 +776,21 @@ int flac__encode_wav(FILE *infile, long infilesize, const char *infilename, cons
                                }
                        }
 
+                       if(trim > 0) {
+                               if(fseek(infile, bytes_per_wide_sample * (unsigned)trim, SEEK_CUR) < 0) {
+                                       /* can't seek input, read ahead manually... */
+                                       unsigned left, need;
+                                       for(left = (unsigned)trim; left > 0; ) { /*@@@ WATCHOUT: 4GB limit */
+                                               need = min(left, CHUNK_OF_SAMPLES);
+                                               if(fread(ucbuffer_, bytes_per_wide_sample, need, infile) < need) {
+                                                       fprintf(stderr, "%s: ERROR during read while skipping samples\n", encoder_session.inbasefilename);
+                                                       return EncoderSession_finish_error(&encoder_session);
+                                               }
+                                               left -= need;
+                                       }
+                               }
+                       }
+
                        /*
                         * now read unaligned samples into reservoir or pad with zeroes if necessary
                         */