soc: bcm: bcm2835-power: Add support for BCM2712
authorPhil Elwell <phil@raspberrypi.com>
Wed, 8 Mar 2023 14:42:48 +0000 (14:42 +0000)
committerDom Cobley <popcornmix@gmail.com>
Mon, 19 Feb 2024 11:34:50 +0000 (11:34 +0000)
BCM2712 has a PM block but neither ASB nor RPIVID_ASB. Use the absence
of the "asb" register range to indicate BCM2712 and its different PM
register range.

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
drivers/pmdomain/bcm/bcm2835-power.c

index d2f0233..5812f2a 100644 (file)
@@ -79,6 +79,7 @@
 #define PM_IMAGE                       0x108
 #define PM_GRAFX                       0x10c
 #define PM_PROC                                0x110
+#define PM_GRAFX_2712                  0x304
 #define PM_ENAB                                BIT(12)
 #define PM_ISPRSTN                     BIT(8)
 #define PM_H264RSTN                    BIT(7)
@@ -381,6 +382,9 @@ static int bcm2835_power_pd_power_on(struct generic_pm_domain *domain)
                return bcm2835_power_power_on(pd, PM_GRAFX);
 
        case BCM2835_POWER_DOMAIN_GRAFX_V3D:
+               if (!power->asb)
+                       return bcm2835_asb_power_on(pd, PM_GRAFX_2712,
+                                                   0, 0, PM_V3DRSTN);
                return bcm2835_asb_power_on(pd, PM_GRAFX,
                                            ASB_V3D_M_CTRL, ASB_V3D_S_CTRL,
                                            PM_V3DRSTN);
@@ -447,6 +451,9 @@ static int bcm2835_power_pd_power_off(struct generic_pm_domain *domain)
                return bcm2835_power_power_off(pd, PM_GRAFX);
 
        case BCM2835_POWER_DOMAIN_GRAFX_V3D:
+               if (!power->asb)
+                       return bcm2835_asb_power_off(pd, PM_GRAFX_2712,
+                                                   0, 0, PM_V3DRSTN);
                return bcm2835_asb_power_off(pd, PM_GRAFX,
                                             ASB_V3D_M_CTRL, ASB_V3D_S_CTRL,
                                             PM_V3DRSTN);
@@ -642,19 +649,21 @@ static int bcm2835_power_probe(struct platform_device *pdev)
        power->asb = pm->asb;
        power->rpivid_asb = pm->rpivid_asb;
 
-       id = readl(power->asb + ASB_AXI_BRDG_ID);
-       if (id != BCM2835_BRDG_ID /* "BRDG" */) {
-               dev_err(dev, "ASB register ID returned 0x%08x\n", id);
-               return -ENODEV;
-       }
-
-       if (power->rpivid_asb) {
-               id = readl(power->rpivid_asb + ASB_AXI_BRDG_ID);
+       if (power->asb) {
+               id = readl(power->asb + ASB_AXI_BRDG_ID);
                if (id != BCM2835_BRDG_ID /* "BRDG" */) {
-                       dev_err(dev, "RPiVid ASB register ID returned 0x%08x\n",
-                                    id);
+                       dev_err(dev, "ASB register ID returned 0x%08x\n", id);
                        return -ENODEV;
                }
+
+               if (power->rpivid_asb) {
+                       id = readl(power->rpivid_asb + ASB_AXI_BRDG_ID);
+                       if (id != BCM2835_BRDG_ID /* "BRDG" */) {
+                               dev_err(dev, "RPiVid ASB register ID returned 0x%08x\n",
+                                       id);
+                               return -ENODEV;
+                       }
+               }
        }
 
        power->pd_xlate.domains = devm_kcalloc(dev,