Added debug logger and make sure that we are using it if '-d' in use.
authorAlexander Kanevskiy <alexander.kanevskiy@intel.com>
Fri, 16 Aug 2013 12:05:23 +0000 (15:05 +0300)
committerAlexander Kanevskiy <alexander.kanevskiy@intel.com>
Fri, 16 Aug 2013 12:05:23 +0000 (15:05 +0300)
gerrithooks-log.conf
gerrithooks/common.py

index 83178e1461ef12c6e9352fcbbf0ee85426ec843f..a5537179e8bc721d3416cea9637195204706b2fc 100644 (file)
@@ -11,6 +11,12 @@ keys=simpleFormatter
 level=DEBUG
 handlers=consoleHandler
 
+[logger_gerrithooks_debug]
+level=DEBUG
+handlers=SysLogHandler,consoleHandler
+qualname=gerrithooks
+propagate=0
+
 [logger_gerrithooks]
 level=DEBUG
 handlers=SysLogHandler
index aa69bf2e4e83a50b328a5d54ac5a6942aab11ee3..d1480b8381efae838b0d775c81a442d736fb4d85 100644 (file)
@@ -33,9 +33,6 @@ def run_plugin_hooks(hook, parser):
     Common code for every hook. Must provide parsed params and logger
     """
 
-    # set up logger
-    logger = configure_logging("gerrithooks")
-
     # get parameters from command line
     params = parser(sys.argv[1:])
     if isinstance(params, types.TupleType):
@@ -43,8 +40,12 @@ def run_plugin_hooks(hook, parser):
     else:
         extra_params = None
 
+    # set up logger
+    logger = configure_logging(["gerrithooks","gerrithooks_debug"]\
+                                                        [int(params.debug)])
+
     params_keys = sorted([ key for key in dir(params)
-                    if not (key.startswith("_") or key =="debug") ])
+            if not (key.startswith("_") or key =="debug" or key == "comment") ])
     params_string = ", ".join(["%s: %s" % (key, getattr(params, key)) for key in
                                                             params_keys ])
     if not 'debug' in params or not params.debug: