metag: off by one in setup_bootmem_node()
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 8 Nov 2013 09:45:33 +0000 (12:45 +0300)
committerJames Hogan <james.hogan@imgtec.com>
Fri, 8 Nov 2013 11:23:00 +0000 (11:23 +0000)
If "nid == MAX_NUMNODES" then we write beyond the end of the node_data[]
array.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: James Hogan <james.hogan@imgtec.com>
arch/metag/mm/numa.c

index 9ae578c..b172aa4 100644 (file)
@@ -34,7 +34,7 @@ void __init setup_bootmem_node(int nid, unsigned long start, unsigned long end)
        unsigned long pgdat_paddr;
 
        /* Don't allow bogus node assignment */
-       BUG_ON(nid > MAX_NUMNODES || nid <= 0);
+       BUG_ON(nid >= MAX_NUMNODES || nid <= 0);
 
        start_pfn = start >> PAGE_SHIFT;
        end_pfn = end >> PAGE_SHIFT;