check for NULLness and warn if we can't report GError

Original commit message from CVS:
check for NULLness and warn if we can't report GError

diff --git a/ChangeLog b/ChangeLog
index ec86a2c..a53c5de 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2004-02-02  Thomas Vander Stichele  <thomas at apestaart dot org>
+
+       * gst-libs/gst/play/play.c: (gst_play_new):
+          check for GError
+
 2004-02-01  Julien MOUTTE  <julien@moutte.net>
 
        * gst-libs/gst/play/play.c: (gst_play_seek_to_time),

diff --git a/gst-libs/gst/play/play.c b/gst-libs/gst/play/play.c
index ba100fb..46738fd 100644 (file)
--- a/gst-libs/gst/play/play.c
+++ b/gst-libs/gst/play/play.c
@@ -1133,12 +1133,19 @@ gst_play_new (GError **error)
 {
   GstPlay *play = g_object_new (GST_TYPE_PLAY, NULL);
 
-  if ( (error) && (play->priv->error) )
+  if (play->priv->error)
   {
-    *error = play->priv->error;
-    play->priv->error = NULL;
+    if (error)
+    {
+      *error = play->priv->error;
+      play->priv->error = NULL;
+    }
+    else
+    {
+      g_warning ("Error creating GstPlay object.\n%s", play->priv->error->message);
+      g_error_free (play->priv->error);
+    }
   }
-  
   return play;
 }