pinctrl: bcm: fix kconfig dependency warning when !GPIOLIB
authorNecip Fazil Yildiran <fazilyildiran@gmail.com>
Mon, 14 Sep 2020 14:40:26 +0000 (17:40 +0300)
committerLinus Walleij <linus.walleij@linaro.org>
Tue, 29 Sep 2020 12:58:56 +0000 (14:58 +0200)
When PINCTRL_BCM2835 is enabled and GPIOLIB is disabled, it results in the
following Kbuild warning:

WARNING: unmet direct dependencies detected for GPIOLIB_IRQCHIP
  Depends on [n]: GPIOLIB [=n]
  Selected by [y]:
  - PINCTRL_BCM2835 [=y] && PINCTRL [=y] && OF [=y] && (ARCH_BCM2835 [=n] || ARCH_BRCMSTB [=n] || COMPILE_TEST [=y])

The reason is that PINCTRL_BCM2835 selects GPIOLIB_IRQCHIP without
depending on or selecting GPIOLIB while GPIOLIB_IRQCHIP is subordinate to
GPIOLIB.

Honor the kconfig menu hierarchy to remove kconfig dependency warnings.

Fixes: 85ae9e512f43 ("pinctrl: bcm2835: switch to GPIOLIB_IRQCHIP")
Signed-off-by: Necip Fazil Yildiran <fazilyildiran@gmail.com>
Link: https://lore.kernel.org/r/20200914144025.371370-1-fazilyildiran@gmail.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/bcm/Kconfig

index dcf7df7..0ed14de 100644 (file)
@@ -23,6 +23,7 @@ config PINCTRL_BCM2835
        select PINMUX
        select PINCONF
        select GENERIC_PINCONF
+       select GPIOLIB
        select GPIOLIB_IRQCHIP
        default ARCH_BCM2835 || ARCH_BRCMSTB
        help