sparc: piggyback: handle invalid image

With an old elftoaout, the generation of tftpboot.img fail with "lseek:
invalid argument".
This is due to offset being negative.

Instead of printing this error message, let's print a better one.

Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/arch/sparc/boot/piggyback.c b/arch/sparc/boot/piggyback.c
index a7a38fb..6d74064 100644 (file)
--- a/arch/sparc/boot/piggyback.c
+++ b/arch/sparc/boot/piggyback.c
@@ -154,6 +154,10 @@ static off_t get_hdrs_offset(int kernelfd, const char *filename)
                offset -= LOOKBACK;
                /* skip a.out header */
                offset += AOUT_TEXT_OFFSET;
+               if (offset < 0) {
+                       errno = -EINVAL;
+                       die("Calculated a negative offset, probably elftoaout generated an invalid image. Did you use a recent elftoaout ?");
+               }
                if (lseek(kernelfd, offset, SEEK_SET) < 0)
                        die("lseek");
                if (read(kernelfd, buffer, BUFSIZE) != BUFSIZE)