HID: cp2112: Use sysfs_emit() to instead of scnprintf()
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Mon, 3 Jul 2023 18:52:20 +0000 (21:52 +0300)
committerBenjamin Tissoires <bentiss@kernel.org>
Fri, 28 Jul 2023 15:05:48 +0000 (17:05 +0200)
Follow the advice of the Documentation/filesystems/sysfs.rst and show()
should only use sysfs_emit() or sysfs_emit_at() when formatting the
value to be returned to user space.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20230703185222.50554-11-andriy.shevchenko@linux.intel.com
Signed-off-by: Benjamin Tissoires <bentiss@kernel.org>
drivers/hid/hid-cp2112.c

index 2eebb2b..1e45f54 100644 (file)
@@ -893,7 +893,7 @@ static ssize_t name##_show(struct device *kdev, \
        int ret = cp2112_get_usb_config(hdev, &cfg); \
        if (ret) \
                return ret; \
-       return scnprintf(buf, PAGE_SIZE, format, ##__VA_ARGS__); \
+       return sysfs_emit(buf, format, ##__VA_ARGS__); \
 } \
 static DEVICE_ATTR_RW(name);