net: ethernet: mtk_wed: No need to clear memory after a dma_alloc_coherent() call
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sun, 12 Feb 2023 06:51:51 +0000 (07:51 +0100)
committerJakub Kicinski <kuba@kernel.org>
Tue, 14 Feb 2023 03:45:46 +0000 (19:45 -0800)
dma_alloc_coherent() already clears the allocated memory, there is no need
to explicitly call memset().

Moreover, it is likely that the size in the memset() is incorrect and
should be "size * sizeof(*ring->desc)".

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/d5acce7dd108887832c9719f62c7201b4c83b3fb.1676184599.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/mediatek/mtk_wed.c

index 95ac4f7..95d8908 100644 (file)
@@ -787,7 +787,6 @@ mtk_wed_rro_ring_alloc(struct mtk_wed_device *dev, struct mtk_wed_ring *ring,
 
        ring->desc_size = sizeof(*ring->desc);
        ring->size = size;
-       memset(ring->desc, 0, size);
 
        return 0;
 }