rw-update-ani-common : hot fix - target linking missing DSO

fota_gui_common, recovery_gui_common, rw-update-ani-common : if using rotate_angle, rotate_state from input, it has to consider integer overflow

Change-Id: Ib09725bdae947576e2b5f79195ea0c0323db6b70

diff --git a/fota_gui_common/fota_gr_direct_ro_common.c b/fota_gui_common/fota_gr_direct_ro_common.c
index 2169cd5f5d204e0211d81851380a2247a8c8b54b..8b3ebb5e76679a744a27e47bd1b071a0dd2aae67 100644 (file)
--- a/fota_gui_common/fota_gr_direct_ro_common.c
+++ b/fota_gui_common/fota_gr_direct_ro_common.c
@@ -634,9 +634,13 @@ void _get_rotate(void)
                rotate_angle = atoi(rotate_state);
        }
 
+       if(rotate_angle < -360 || rotate_angle > 360)  // for prevent interger overflow
+               rotate_angle = 0;
        LOG("Print Rotate Angle value = %d\n", rotate_angle);
 
        rotate_step = (rotate_angle + 360) / 90 % 4;
+       if(rotate_step < 0 || rotate_step > 4) // for prevent interger overflow
+               rotate_step = 0;
        rollback_step = (4 - rotate_step) % 4;
        LOG("rotate_step = %d, rollback_step = %d\n", rotate_step, rollback_step);
 

diff --git a/recovery_gui_common/recovery_gr_direct_common.c b/recovery_gui_common/recovery_gr_direct_common.c
index 021ae2c204390cca081351340a65320f3f9a0c65..1e62197d26a48c1dedc8809ec9f7695d47dcdcb0 100644 (file)
--- a/recovery_gui_common/recovery_gr_direct_common.c
+++ b/recovery_gui_common/recovery_gr_direct_common.c
@@ -627,9 +627,13 @@ void _get_rotate(void)
                rotate_angle = atoi(rotate_state);
        }
 
+       if(rotate_angle < -360 || rotate_angle > 360)  // for prevent interger overflow
+               rotate_angle = 0;
        LOG("Print Rotate Angle value = %d\n", rotate_angle);
 
        rotate_step = (rotate_angle + 360) / 90 % 4;
+       if(rotate_step < 0 || rotate_step > 4) // for prevent interger overflow
+               rotate_step = 0;
        rollback_step = (4 - rotate_step) % 4;
        LOG("rotate_step = %d, rollback_step = %d\n", rotate_step, rollback_step);
 

diff --git a/rw-update-ani-common/CMakeLists.txt b/rw-update-ani-common/CMakeLists.txt
index 1a6d7b70be70e4c9f4bac9d08bf5316c0f4048ed..6ed7f887f0e75854ac962cd0e57017d0bafcce6c 100644 (file)
--- a/rw-update-ani-common/CMakeLists.txt
+++ b/rw-update-ani-common/CMakeLists.txt
@@ -57,7 +57,7 @@ ENDIF("${ARCH}" STREQUAL "arm")
 SET(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -Wl,--as-needed -pie")
 
 ADD_EXECUTABLE(${PROJECT_NAME} ${GUI_SRCS})
-TARGET_LINK_LIBRARIES(${PROJECT_NAME} ${gui_pkgs_LDFLAGS} ${LIBS} -lpthread)
+TARGET_LINK_LIBRARIES(${PROJECT_NAME} ${pkgs_ani_LDFLAGS} ${LIBS} -lpthread)
 
 ADD_DEFINITIONS("-DRESDIR=\"${RESDIR}\"")
 ADD_DEFINITIONS("-DROTATE=0")

diff --git a/rw-update-ani-common/fota_gr_direct_rw_common.c b/rw-update-ani-common/fota_gr_direct_rw_common.c
index 9cba1b23c4b8bed27bd80904e899cb50414d6f30..901bf2590a376818ed9e8e0dd5862fabdaac27e0 100644 (file)
--- a/rw-update-ani-common/fota_gr_direct_rw_common.c
+++ b/rw-update-ani-common/fota_gr_direct_rw_common.c
@@ -645,9 +645,13 @@ void _get_rotate(void)
                rotate_angle = atoi(rotate_state);
        }
 
+       if(rotate_angle < -360 || rotate_angle > 360)  // for prevent interger overflow
+               rotate_angle = 0;
        LOG("Print Rotate Angle value = %d\n", rotate_angle);
 
        rotate_step = (rotate_angle + 360) / 90 % 4;
+       if(rotate_step < 0 || rotate_step > 4) // for prevent interger overflow
+               rotate_step = 0;
        rollback_step = (4 - rotate_step) % 4;
        LOG("rotate_step = %d, rollback_step = %d\n", rotate_step, rollback_step);