pwm: img: Use regmap_clear_bits and regmap_set_bits where applicable
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Fri, 2 Dec 2022 18:35:15 +0000 (19:35 +0100)
committerThierry Reding <thierry.reding@gmail.com>
Tue, 6 Dec 2022 11:46:09 +0000 (12:46 +0100)
Found using coccinelle and the following semantic patch:

@@
expression map, reg, bits;
@@

- regmap_update_bits(map, reg, bits, bits)
+ regmap_set_bits(map, reg, bits)

@@
expression map, reg, bits;
@@

- regmap_update_bits(map, reg, bits, 0)
+ regmap_clear_bits(map, reg, bits)

Link: https://lore.kernel.org/r/20221115111347.3705732-3-u.kleine-koenig@pengutronix.de
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
drivers/pwm/pwm-img.c

index 0fccf06..89362af 100644 (file)
@@ -161,9 +161,9 @@ static int img_pwm_enable(struct pwm_chip *chip, struct pwm_device *pwm)
        val |= BIT(pwm->hwpwm);
        img_pwm_writel(imgchip, PWM_CTRL_CFG, val);
 
-       regmap_update_bits(imgchip->periph_regs, PERIP_PWM_PDM_CONTROL,
-                          PERIP_PWM_PDM_CONTROL_CH_MASK <<
-                          PERIP_PWM_PDM_CONTROL_CH_SHIFT(pwm->hwpwm), 0);
+       regmap_clear_bits(imgchip->periph_regs, PERIP_PWM_PDM_CONTROL,
+                         PERIP_PWM_PDM_CONTROL_CH_MASK <<
+                         PERIP_PWM_PDM_CONTROL_CH_SHIFT(pwm->hwpwm));
 
        return 0;
 }
@@ -397,11 +397,10 @@ static int img_pwm_resume(struct device *dev)
 
        for (i = 0; i < imgchip->chip.npwm; i++)
                if (imgchip->suspend_ctrl_cfg & BIT(i))
-                       regmap_update_bits(imgchip->periph_regs,
-                                          PERIP_PWM_PDM_CONTROL,
-                                          PERIP_PWM_PDM_CONTROL_CH_MASK <<
-                                          PERIP_PWM_PDM_CONTROL_CH_SHIFT(i),
-                                          0);
+                       regmap_clear_bits(imgchip->periph_regs,
+                                         PERIP_PWM_PDM_CONTROL,
+                                         PERIP_PWM_PDM_CONTROL_CH_MASK <<
+                                         PERIP_PWM_PDM_CONTROL_CH_SHIFT(i));
 
        if (pm_runtime_status_suspended(dev))
                img_pwm_runtime_suspend(dev);