ALSA: hda - Use LPIB for ATI/AMD chipsets as default
authorTakashi Iwai <tiwai@suse.de>
Fri, 20 May 2011 14:29:09 +0000 (16:29 +0200)
committerTakashi Iwai <tiwai@suse.de>
Fri, 20 May 2011 14:29:09 +0000 (16:29 +0200)
ATI and AMD chipsets seem not providing the proper position-buffer
information, and it also doesn't provide FIFO register required by
VIACOMBO fix.  It's better to use LPIB for these.

Reported-by: David Henningsson <david.henningsson@canonical.com>
Cc: <stable@kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/hda_intel.c

index 0c1996d..43a0367 100644 (file)
@@ -2367,9 +2367,16 @@ static int __devinit check_position_fix(struct azx *chip, int fix)
        /* Check VIA/ATI HD Audio Controller exist */
        switch (chip->driver_type) {
        case AZX_DRIVER_VIA:
-       case AZX_DRIVER_ATI:
                /* Use link position directly, avoid any transfer problem. */
                return POS_FIX_VIACOMBO;
+       case AZX_DRIVER_ATI:
+               /* ATI chipsets don't work well with position-buffer */
+               return POS_FIX_LPIB;
+       case AZX_DRIVER_GENERIC:
+               /* AMD chipsets also don't work with position-buffer */
+               if (chip->pci->vendor == PCI_VENDOR_ID_AMD)
+                       return POS_FIX_LPIB;
+               break;
        }
 
        return POS_FIX_AUTO;