[media] gspca: dubious one-bit signed bitfield
authorEmil Goode <emilgoode@gmail.com>
Sun, 5 Aug 2012 12:34:26 +0000 (09:34 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Thu, 13 Sep 2012 20:42:15 +0000 (17:42 -0300)
This patch changes some signed integers to unsigned because
they are not intended for negative values and sparse
is making noise about it.

Sparse gives eight of these errors:
drivers/media/usb/gspca/ov519.c:144:29: error: dubious one-bit signed bitfield

Signed-off-by: Emil Goode <emilgoode@gmail.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/usb/gspca/ov519.c

index bfc7cef..c1a21bf 100644 (file)
@@ -141,14 +141,14 @@ enum sensors {
 
 /* table of the disabled controls */
 struct ctrl_valid {
-       int has_brightness:1;
-       int has_contrast:1;
-       int has_exposure:1;
-       int has_autogain:1;
-       int has_sat:1;
-       int has_hvflip:1;
-       int has_autobright:1;
-       int has_freq:1;
+       unsigned int has_brightness:1;
+       unsigned int has_contrast:1;
+       unsigned int has_exposure:1;
+       unsigned int has_autogain:1;
+       unsigned int has_sat:1;
+       unsigned int has_hvflip:1;
+       unsigned int has_autobright:1;
+       unsigned int has_freq:1;
 };
 
 static const struct ctrl_valid valid_controls[] = {