media: i2c: tda1997: Fix an error handling path 'tda1997x_probe()'
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Tue, 8 May 2018 06:14:15 +0000 (02:14 -0400)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Fri, 11 May 2018 15:36:09 +0000 (11:36 -0400)
If 'media_entity_pads_init()' fails, we must free the resources allocated
by 'v4l2_ctrl_handler_init()', as already done in the previous error
handling path.

'goto' the right label to fix it.

Fixes: 9ac0038db9a7 ("media: i2c: Add TDA1997x HDMI receiver driver")

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Hans Verkuil <hansverk@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/i2c/tda1997x.c

index 1c5b5f7..b697c6f 100644 (file)
@@ -2721,7 +2721,7 @@ static int tda1997x_probe(struct i2c_client *client,
                state->pads);
        if (ret) {
                v4l_err(client, "failed entity_init: %d", ret);
-               goto err_free_mutex;
+               goto err_free_handler;
        }
 
        ret = v4l2_async_register_subdev(sd);