ASoC: qcom: q6dsp: Fix an off-by-one in q6adm_alloc_copp()
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Thu, 21 Jul 2022 09:02:22 +0000 (11:02 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 Aug 2022 12:24:10 +0000 (14:24 +0200)
[ Upstream commit 673f58f62ca6fc98979d1cf3fe89c3ff33f29b2e ]

find_first_zero_bit() returns MAX_COPPS_PER_PORT at max here.
So 'idx' should be tested with ">=" or the test can't match.

Fixes: 7b20b2be51e1 ("ASoC: qdsp6: q6adm: Add q6adm driver")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/0fca3271649736053eb9649d87e1ca01b056be40.1658394124.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/soc/qcom/qdsp6/q6adm.c

index 3d831b6..4ae97af 100644 (file)
@@ -217,7 +217,7 @@ static struct q6copp *q6adm_alloc_copp(struct q6adm *adm, int port_idx)
        idx = find_first_zero_bit(&adm->copp_bitmap[port_idx],
                                  MAX_COPPS_PER_PORT);
 
-       if (idx > MAX_COPPS_PER_PORT)
+       if (idx >= MAX_COPPS_PER_PORT)
                return ERR_PTR(-EBUSY);
 
        c = kzalloc(sizeof(*c), GFP_ATOMIC);