ASoC: dmaengine: Remove unused SND_DMAENGINE_PCM_FLAG_CUSTOM_CHANNEL_NAME flag 59/197859/6
authorSylwester Nawrocki <s.nawrocki@samsung.com>
Thu, 14 Feb 2019 15:45:55 +0000 (16:45 +0100)
committerSylwester Nawrocki <s.nawrocki@samsung.com>
Mon, 4 Mar 2019 17:05:33 +0000 (18:05 +0100)
There is now no users of this flag so remove it together with
related code.  The chan_name field of snd_dmaengine_dai_dma_data
data structure is not removed as it is still in use by the PXA
platform.

Change-Id: Ia8bb6022ce7c5e85abb7c5410459130666785f45
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
include/sound/dmaengine_pcm.h
sound/soc/soc-generic-dmaengine-pcm.c

index 67be244..3e43b89 100644 (file)
@@ -107,10 +107,6 @@ void snd_dmaengine_pcm_set_config_from_dai_data(
  * playback.
  */
 #define SND_DMAENGINE_PCM_FLAG_HALF_DUPLEX BIT(3)
-/*
- * The PCM streams have custom channel names specified.
- */
-#define SND_DMAENGINE_PCM_FLAG_CUSTOM_CHANNEL_NAME BIT(4)
 
 /**
  * struct snd_dmaengine_pcm_config - Configuration data for dmaengine based PCM
index 06d4dfc..8a55d3f 100644 (file)
@@ -263,7 +263,6 @@ static int dmaengine_pcm_new(struct snd_soc_pcm_runtime *rtd)
        struct dmaengine_pcm *pcm = soc_platform_to_pcm(rtd->platform);
        const struct snd_dmaengine_pcm_config *config = pcm->config;
        struct device *dev = rtd->platform->dev;
-       struct snd_dmaengine_dai_dma_data *dma_data;
        struct snd_pcm_substream *substream;
        size_t prealloc_buffer_size;
        size_t max_buffer_size;
@@ -283,19 +282,9 @@ static int dmaengine_pcm_new(struct snd_soc_pcm_runtime *rtd)
                if (!substream)
                        continue;
 
-               dma_data = snd_soc_dai_get_dma_data(rtd->cpu_dai, substream);
-
-               if (!pcm->chan[i] &&
-                   ((pcm->flags & SND_DMAENGINE_PCM_FLAG_CUSTOM_CHANNEL_NAME) ||
-                    (config && config->chan_names[i]))) {
-                       const char *chan_name = dma_data->chan_name;
-
-                       if (config && config->chan_names[i])
-                               chan_name = config->chan_names[i];
-
+               if (!pcm->chan[i] && config && config->chan_names[i])
                        pcm->chan[i] = dma_request_slave_channel(dev,
-                               chan_name);
-               }
+                               config->chan_names[i]);
 
                if (!pcm->chan[i] && (pcm->flags & SND_DMAENGINE_PCM_FLAG_COMPAT)) {
                        pcm->chan[i] = dmaengine_pcm_compat_request_channel(rtd,
@@ -365,10 +354,8 @@ static int dmaengine_pcm_request_chan_of(struct dmaengine_pcm *pcm,
        const char *name;
        struct dma_chan *chan;
 
-       if ((pcm->flags & (SND_DMAENGINE_PCM_FLAG_NO_DT |
-                          SND_DMAENGINE_PCM_FLAG_CUSTOM_CHANNEL_NAME)) ||
-            (!dev->of_node && !(config && config->dma_dev &&
-                               config->dma_dev->of_node)))
+       if ((pcm->flags & SND_DMAENGINE_PCM_FLAG_NO_DT) || (!dev->of_node &&
+           !(config && config->dma_dev && config->dma_dev->of_node)))
                return 0;
 
        if (config && config->dma_dev) {