qcow2: Avoid shadowing variable in alloc_clusters_noref()
authorStefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Sat, 17 Apr 2010 09:49:07 +0000 (10:49 +0100)
committerKevin Wolf <kwolf@redhat.com>
Mon, 3 May 2010 08:07:31 +0000 (10:07 +0200)
The i loop iterator is shadowed by the next free cluster index.  Both
using the variable name 'i' makes the code harder to read.

Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
block/qcow2-refcount.c

index 2661493..95491d3 100644 (file)
@@ -556,8 +556,8 @@ static int64_t alloc_clusters_noref(BlockDriverState *bs, int64_t size)
     nb_clusters = size_to_clusters(s, size);
 retry:
     for(i = 0; i < nb_clusters; i++) {
-        int64_t i = s->free_cluster_index++;
-        if (get_refcount(bs, i) != 0)
+        int64_t next_cluster_index = s->free_cluster_index++;
+        if (get_refcount(bs, next_cluster_index) != 0)
             goto retry;
     }
 #ifdef DEBUG_ALLOC2