drm/nouveau/gem: fix object reference leak in a failure path

Reported-by: Maarten Lankhorst <maarten.lankhorst@canonical.com>
Signed-off-by: Ben Skeggs <bskeggs@redhat.com>
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@canonical.com>

diff --git a/drivers/gpu/drm/nouveau/nouveau_gem.c b/drivers/gpu/drm/nouveau/nouveau_gem.c
index 30f5423169444ec841d9af44f0d816cb3547ae17..34d0bc59621342521ef9cfe4b81f109932fffd9d 100644 (file)
--- a/drivers/gpu/drm/nouveau/nouveau_gem.c
+++ b/drivers/gpu/drm/nouveau/nouveau_gem.c
@@ -342,6 +342,7 @@ retry:
                if (nvbo->reserved_by && nvbo->reserved_by == file_priv) {
                        NV_ERROR(dev, "multiple instances of buffer %d on "
                                      "validation list\n", b->handle);
+                       drm_gem_object_unreference_unlocked(gem);
                        validate_fini(op, NULL);
                        return -EINVAL;
                }