mmc: dw_mmc: hi3789cv200: Obviously always return success in remove callback
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Fri, 10 Jun 2022 21:12:54 +0000 (23:12 +0200)
committerUlf Hansson <ulf.hansson@linaro.org>
Tue, 12 Jul 2022 10:25:37 +0000 (12:25 +0200)
dw_mci_pltfm_remove() returns 0 unconditionally and returning an error
in a platform remove callback isn't very sensible. (The only effect of
the latter is that the device core emits a generic warning and then
removes the device anyhow.)

So return 0 unconditionally to make it obvious there is no error
forwarded to the upper layers.

This is a preparation for making platform remove callbacks return void.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20220610211257.102071-2-u.kleine-koenig@pengutronix.de
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/dw_mmc-hi3798cv200.c

index e9437ef..6f22fe0 100644 (file)
@@ -179,7 +179,9 @@ static int dw_mci_hi3798cv200_remove(struct platform_device *pdev)
        clk_disable_unprepare(priv->drive_clk);
        clk_disable_unprepare(priv->sample_clk);
 
-       return dw_mci_pltfm_remove(pdev);
+       dw_mci_pltfm_remove(pdev);
+
+       return 0;
 }
 
 static const struct of_device_id dw_mci_hi3798cv200_match[] = {