drm/amdgpu/smu10: remove duplicate assignment of smu10_hwmgr_funcs members
authorJason Yan <yanaijie@huawei.com>
Tue, 28 Apr 2020 06:30:03 +0000 (14:30 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 30 Apr 2020 20:48:07 +0000 (16:48 -0400)
The struct member 'asic_setup' was assigned twice, let's remove one:

static const struct pp_hwmgr_func smu10_hwmgr_funcs = {
......
.asic_setup = NULL,
......
.asic_setup = smu10_setup_asic_task,
......
};

This fixes the following coccicheck warning:

drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c:1357:52-53:
asic_setup: first occurrence line 1360, second occurrence line 1388

Signed-off-by: Jason Yan <yanaijie@huawei.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c

index 1cc30f7..4f8c1b8 100644 (file)
@@ -1357,7 +1357,6 @@ static int smu10_asic_reset(struct pp_hwmgr *hwmgr, enum SMU_ASIC_RESET_MODE mod
 static const struct pp_hwmgr_func smu10_hwmgr_funcs = {
        .backend_init = smu10_hwmgr_backend_init,
        .backend_fini = smu10_hwmgr_backend_fini,
-       .asic_setup = NULL,
        .apply_state_adjust_rules = smu10_apply_state_adjust_rules,
        .force_dpm_level = smu10_dpm_force_dpm_level,
        .get_power_state_size = smu10_get_power_state_size,