toolbar: remove useless call to _sizing_eval.
authorCedric BAIL <cedric@osg.samsung.com>
Thu, 15 Oct 2015 23:31:00 +0000 (16:31 -0700)
committerCedric BAIL <cedric@osg.samsung.com>
Thu, 15 Oct 2015 23:38:24 +0000 (16:38 -0700)
_sizing_eval is very costly on toolbar as it recalc all edje part and sends
signal to all of them. _item_theme_hook was already calling _sizing_eval
doubling the cost of adding new item.

src/lib/elm_toolbar.c

index df2ab9043d9d03f9b79e2d123a9af83374189b82..e93c552a6d25a4d36061e2ebd8c7cd4fa7432326 100644 (file)
@@ -3010,7 +3010,6 @@ _elm_toolbar_item_append(Eo *obj, Elm_Toolbar_Data *sd, const char *icon, const
    evas_object_show(VIEW(it));
 
    _item_theme_hook(obj, it, scale, sd->icon_size);
-   _sizing_eval(obj);
    sd->item_count++;
 
    return EO_OBJ(it);
@@ -3030,7 +3029,6 @@ _elm_toolbar_item_prepend(Eo *obj, Elm_Toolbar_Data *sd, const char *icon, const
    evas_object_box_prepend(sd->bx, VIEW(it));
    evas_object_show(VIEW(it));
    _item_theme_hook(obj, it, scale, sd->icon_size);
-   _sizing_eval(obj);
    sd->item_count++;
 
    return EO_OBJ(it);
@@ -3054,7 +3052,6 @@ _elm_toolbar_item_insert_before(Eo *obj, Elm_Toolbar_Data *sd, Elm_Object_Item *
        (sd->items, EINA_INLIST_GET(it), EINA_INLIST_GET(_before));
    evas_object_box_insert_before(sd->bx, VIEW(it), VIEW(_before));
    _item_theme_hook(obj, it, scale, sd->icon_size);
-   _sizing_eval(obj);
    sd->item_count++;
 
    return EO_OBJ(it);
@@ -3078,7 +3075,6 @@ _elm_toolbar_item_insert_after(Eo *obj, Elm_Toolbar_Data *sd, Elm_Object_Item *e
        (sd->items, EINA_INLIST_GET(it), EINA_INLIST_GET(_after));
    evas_object_box_insert_after(sd->bx, VIEW(it), VIEW(_after));
    _item_theme_hook(obj, it, scale, sd->icon_size);
-   _sizing_eval(obj);
    sd->item_count++;
 
    return EO_OBJ(it);